Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded ZK operations for setting watches #12866

Merged
merged 1 commit into from
Nov 19, 2021

Conversation

merlimat
Copy link
Contributor

Motivation

After the change to use ZK persistent watches (#11198), we don't need anymore to perform followup getData() or exists() calls after a NONODE error, with the purpose of setting a watch on the non-existing z-node.

With persistent watches, we're going to get the watch notification in any case.

@merlimat merlimat added the type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages label Nov 18, 2021
@merlimat merlimat added this to the 2.10.0 milestone Nov 18, 2021
@merlimat merlimat self-assigned this Nov 18, 2021
@github-actions
Copy link

@merlimat:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@merlimat merlimat added doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels Nov 18, 2021
@codelipenghui codelipenghui merged commit 0977044 into apache:master Nov 19, 2021
@merlimat merlimat deleted the zk-remove-unneeded-code branch November 19, 2021 19:45
dlg99 pushed a commit to dlg99/pulsar that referenced this pull request Nov 23, 2021
eolivelli pushed a commit to eolivelli/pulsar that referenced this pull request Nov 29, 2021
fxbing pushed a commit to fxbing/pulsar that referenced this pull request Dec 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-not-needed Your PR changes do not impact docs type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants