Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PIP-118: reconnect broker when ZooKeeper session expires #13341

Merged
merged 2 commits into from
Feb 17, 2022
Merged

PIP-118: reconnect broker when ZooKeeper session expires #13341

merged 2 commits into from
Feb 17, 2022

Conversation

HQebupt
Copy link
Contributor

@HQebupt HQebupt commented Dec 15, 2021

Fixes #13304

Motivation

See #13304

Modifications

Change zookeeperSessionExpiredPolicy default value from shutdown to reconnect instead of in the broker.conf.

Verifying this change

  • Make sure that the change passes the CI checks.

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (no)

Documentation

Check the box below and label this PR (if you have committer privilege).

Need to update docs?

  • no-need-doc

    (There is description in the configuration modification)

@codelipenghui codelipenghui added this to the 2.10.0 milestone Dec 15, 2021
@github-actions
Copy link

@HQebupt:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

merlimat
merlimat requested changes Dec 15, 2021
View reviewed changes
Copy link
Contributor

@merlimat merlimat left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good though let's wait until the PIP is officially voted and accepted, before merging this.

shoothzj
shoothzj previously approved these changes Dec 15, 2021
View reviewed changes
@HQebupt
Copy link
Contributor Author

HQebupt commented Dec 16, 2021

/pulsarbot run-failure-checks

3 similar comments
@HQebupt
Copy link
Contributor Author

HQebupt commented Dec 16, 2021

/pulsarbot run-failure-checks

@HQebupt
Copy link
Contributor Author

HQebupt commented Dec 16, 2021

/pulsarbot run-failure-checks

@HQebupt
Copy link
Contributor Author

HQebupt commented Dec 16, 2021

/pulsarbot run-failure-checks

@Anonymitaet Anonymitaet added doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. and removed doc-label-missing labels Dec 16, 2021
@Anonymitaet
Copy link
Member

Hi @HQebupt same comment: #13344 (comment)

@HQebupt
Copy link
Contributor Author

HQebupt commented Dec 16, 2021

/pulsarbot run-failure-checks

eolivelli
eolivelli requested changes Dec 16, 2021
View reviewed changes
Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for your contribution

we should also change the default in ServiceConfiguration

@HQebupt
Copy link
Contributor Author

HQebupt commented Dec 17, 2021

thanks for your contribution

we should also change the default in ServiceConfiguration

You are right, done.

@HQebupt
Copy link
Contributor Author

HQebupt commented Dec 17, 2021

/pulsarbot run-failure-checks

eolivelli
eolivelli previously requested changes Jan 25, 2022
View reviewed changes
Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

but the PIP VOTE thread is not finished
cc @merlimat

@merlimat merlimat dismissed eolivelli’s stale review February 17, 2022 06:26

The PIP was voted and the comment was addressed

@codelipenghui codelipenghui merged commit 66bfa78 into apache:master Feb 17, 2022
codelipenghui pushed a commit that referenced this pull request Feb 17, 2022
@HQebupt @codelipenghui
PIP-118: reconnect broker when ZooKeeper session expires (#13341)
9711525 
(cherry picked from commit 66bfa78)
Nicklee007 pushed a commit to Nicklee007/pulsar that referenced this pull request Apr 20, 2022
@HQebupt
PIP-118: reconnect broker when ZooKeeper session expires (apache#13341)
d6ae087
@poorbarcode poorbarcode mentioned this pull request Aug 20, 2023
Merged
4 tasks
poorbarcode added a commit that referenced this pull request Aug 25, 2023
@poorbarcode
[fix] [bk] Correctct the bookie info after ZK client is reconnected (#…
db20035 
…21035)

Motivation: After [PIP-118: reconnect broker when ZooKeeper session expires](#13341), the Broker will not shut down after losing the connection of the local metadata store in the default configuration. However, before the ZK client is reconnected, the events of BK online and offline are lost, resulting in incorrect BK info in the memory. You can reproduce the issue by the test `BkEnsemblesChaosTest. testBookieInfoIsCorrectEvenIfLostNotificationDueToZKClientReconnect`(90% probability of reproduce of the issue, run it again if the issue does not occur)

Modifications: Refresh BK info in memory after the ZK client is reconnected.
poorbarcode added a commit that referenced this pull request Aug 25, 2023
@poorbarcode
[fix] [bk] Correctct the bookie info after ZK client is reconnected (#…
1f9aa9b 
…21035)

Motivation: After [PIP-118: reconnect broker when ZooKeeper session expires](#13341), the Broker will not shut down after losing the connection of the local metadata store in the default configuration. However, before the ZK client is reconnected, the events of BK online and offline are lost, resulting in incorrect BK info in the memory. You can reproduce the issue by the test `BkEnsemblesChaosTest. testBookieInfoIsCorrectEvenIfLostNotificationDueToZKClientReconnect`(90% probability of reproduce of the issue, run it again if the issue does not occur)

Modifications: Refresh BK info in memory after the ZK client is reconnected.
(cherry picked from commit db20035)
poorbarcode added a commit that referenced this pull request Aug 25, 2023
@poorbarcode
[fix] [bk] Correctct the bookie info after ZK client is reconnected (#…
b2ce012 
…21035)

Motivation: After [PIP-118: reconnect broker when ZooKeeper session expires](#13341), the Broker will not shut down after losing the connection of the local metadata store in the default configuration. However, before the ZK client is reconnected, the events of BK online and offline are lost, resulting in incorrect BK info in the memory. You can reproduce the issue by the test `BkEnsemblesChaosTest. testBookieInfoIsCorrectEvenIfLostNotificationDueToZKClientReconnect`(90% probability of reproduce of the issue, run it again if the issue does not occur)

Modifications: Refresh BK info in memory after the ZK client is reconnected.

(cherry picked from commit db20035)
poorbarcode added a commit that referenced this pull request Aug 25, 2023
@poorbarcode
[fix] [bk] Correctct the bookie info after ZK client is reconnected (#…
5f99925 
…21035)

Motivation: After [PIP-118: reconnect broker when ZooKeeper session expires](#13341), the Broker will not shut down after losing the connection of the local metadata store in the default configuration. However, before the ZK client is reconnected, the events of BK online and offline are lost, resulting in incorrect BK info in the memory. You can reproduce the issue by the test `BkEnsemblesChaosTest. testBookieInfoIsCorrectEvenIfLostNotificationDueToZKClientReconnect`(90% probability of reproduce of the issue, run it again if the issue does not occur)

Modifications: Refresh BK info in memory after the ZK client is reconnected.
(cherry picked from commit db20035)
mukesh-ctds pushed a commit to datastax/pulsar that referenced this pull request Apr 13, 2024
@poorbarcode @mukesh-ctds
[fix] [bk] Correctct the bookie info after ZK client is reconnected (a…
b700488 
…pache#21035)

Motivation: After [PIP-118: reconnect broker when ZooKeeper session expires](apache#13341), the Broker will not shut down after losing the connection of the local metadata store in the default configuration. However, before the ZK client is reconnected, the events of BK online and offline are lost, resulting in incorrect BK info in the memory. You can reproduce the issue by the test `BkEnsemblesChaosTest. testBookieInfoIsCorrectEvenIfLostNotificationDueToZKClientReconnect`(90% probability of reproduce of the issue, run it again if the issue does not occur)

Modifications: Refresh BK info in memory after the ZK client is reconnected.
(cherry picked from commit db20035)
(cherry picked from commit 5f99925)
mukesh-ctds pushed a commit to datastax/pulsar that referenced this pull request Apr 19, 2024
@poorbarcode @mukesh-ctds
[fix] [bk] Correctct the bookie info after ZK client is reconnected (a…
59e7cac 
…pache#21035)

Motivation: After [PIP-118: reconnect broker when ZooKeeper session expires](apache#13341), the Broker will not shut down after losing the connection of the local metadata store in the default configuration. However, before the ZK client is reconnected, the events of BK online and offline are lost, resulting in incorrect BK info in the memory. You can reproduce the issue by the test `BkEnsemblesChaosTest. testBookieInfoIsCorrectEvenIfLostNotificationDueToZKClientReconnect`(90% probability of reproduce of the issue, run it again if the issue does not occur)

Modifications: Refresh BK info in memory after the ZK client is reconnected.
(cherry picked from commit db20035)
(cherry picked from commit 5f99925)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Apr 23, 2024
@poorbarcode @srinath-ctds
[fix] [bk] Correctct the bookie info after ZK client is reconnected (a…
23f6213 
…pache#21035)

Motivation: After [PIP-118: reconnect broker when ZooKeeper session expires](apache#13341), the Broker will not shut down after losing the connection of the local metadata store in the default configuration. However, before the ZK client is reconnected, the events of BK online and offline are lost, resulting in incorrect BK info in the memory. You can reproduce the issue by the test `BkEnsemblesChaosTest. testBookieInfoIsCorrectEvenIfLostNotificationDueToZKClientReconnect`(90% probability of reproduce of the issue, run it again if the issue does not occur)

Modifications: Refresh BK info in memory after the ZK client is reconnected.
(cherry picked from commit db20035)
(cherry picked from commit 5f99925)
@TakaHiR07 TakaHiR07 mentioned this pull request Sep 23, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merlimat merlimat merlimat approved these changes

@Jason918 Jason918 Jason918 approved these changes

@hangc0276 hangc0276 hangc0276 approved these changes

@codelipenghui codelipenghui codelipenghui approved these changes

@shoothzj shoothzj shoothzj left review comments

@eolivelli eolivelli Awaiting requested review from eolivelli

Assignees

@HQebupt HQebupt

Labels
doc Your PR contains doc changes, no matter whether the changes are in markdown or code files.
Projects
None yet
Milestone
2.10.0
Development

Successfully merging this pull request may close these issues.

PIP-118: Do not restart brokers when ZooKeeper session expires
8 participants
@HQebupt @Anonymitaet @merlimat @Jason918 @hangc0276 @eolivelli @codelipenghui @shoothzj