Fix Error in NodeJS consumer code #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was some problems with the URL and also the data packet coming in was a string and should be parsed...
|
Thank you for submitting this pull request, however I do not see a valid CLA on file for you. Before we can merge this request please visit https://yahoocla.herokuapp.com/ and agree to the terms. Thanks! 😄 |
|
CLA is valid! |
merlimat
added
the
doc
sijie
pushed a commit
to sijie/pulsar
that referenced
this pull request
Mar 4, 2018
rdhabalia
added a commit
to rdhabalia/pulsar
that referenced
this pull request
Aug 8, 2019
hrsakai
pushed a commit
to hrsakai/pulsar
that referenced
this pull request
Dec 10, 2020
### Modifications
Enable golangci lint for project, checks as follows:
```
- bodyclose
- deadcode
- gocritic
- goimports
- golint
- gosimple
- govet
- ineffassign
- interfacer
- misspell
- staticcheck
- structcheck
- stylecheck
- typecheck
- unconvert
- unparam
- unused
- varcheck
- lll
- prealloc
- maligned
```
hangc0276
pushed a commit
to hangc0276/pulsar
that referenced
this pull request
May 26, 2021
Master issue: apache#138 This PR adds tests for images of apache#195 . In addition, it fixes the local test error when running tests on MacOS. Because the containers cannot connect to the host's KoP or Kafka service listened on 127.0.0.1. * Fix local tests error by listening to site local address * Add tests for Kafka Java clients * Remove the comments
dlg99
pushed a commit
to dlg99/pulsar
that referenced
this pull request
Oct 3, 2022
* Make BookieId work with PulsarRegistrationDriver * Switch to MetadataCache * checkstyle
dlg99
pushed a commit
to dlg99/pulsar
that referenced
this pull request
Oct 3, 2022
This reverts commit ba3c1d7.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There were some errors in the NodeJS consumer code for webservices
There was some problems with the URL and also the data packet coming in was a string and should be parsed...
The non parsing caused error in Ack which result in queue not deleting
Modifications
I changed two parts in the consumer code document
Result
publish and subscribe now works