Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adminApi: add brokerServiceUrl while creating cluster #140

Merged
merged 1 commit into from
Dec 7, 2016

Conversation

rdhabalia
Copy link
Contributor

Motivation

Store brokerServiceUrl as part of cluster-data so, broker can use brokerServiceUrl for binary-proto-lookup while performing geo-replication.

Modifications

AdminApi Tool/Documentation: pass brokerServiceUrl while creating/updating cluster.

@yahoocla
Copy link

yahoocla commented Dec 3, 2016

CLA is valid!

Copy link
Contributor

@merlimat merlimat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@merlimat merlimat merged commit caba91c into apache:master Dec 7, 2016
@rdhabalia rdhabalia deleted the tools branch June 21, 2017 18:57
sijie pushed a commit to sijie/pulsar that referenced this pull request Mar 4, 2018
hrsakai pushed a commit to hrsakai/pulsar that referenced this pull request Dec 10, 2020
)

* [Issue 140] Consumer should not block on received if closed.

* [Issue apache#140] Consumer should not block on received if closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants