[Metadata] Let entries expire in the metadata caches #14154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- refreshAfterWrite will never expire entries. After the given time, the next request to the entry will trigger a refresh in the background. The current entry will be used until the entry has been refreshed. - documentation for Caffeine's refresh feature: https://github.com/ben-manes/caffeine/wiki/Refresh
|
@lhotari:Thanks for your contribution. For this PR, do we need to update docs? |
1 similar comment
|
@lhotari:Thanks for your contribution. For this PR, do we need to update docs? |
|
@lhotari:Thanks for providing doc info! |
eolivelli
approved these changes
Feb 7, 2022
nicoloboschi
approved these changes
Feb 7, 2022
Jason918
reviewed
Feb 8, 2022
@Jason918 thanks, I changed it in this way. PTAL |
mattisonchao
approved these changes
Feb 8, 2022
Jason918
approved these changes
Feb 8, 2022
gaozhangmin
approved these changes
Feb 8, 2022
codelipenghui
approved these changes
Feb 8, 2022
Nicklee007
pushed a commit
to Nicklee007/pulsar
that referenced
this pull request
Apr 20, 2022
* [Metadata] Let entries expire in the metadata caches - refreshAfterWrite will never expire entries. After the given time, the next request to the entry will trigger a refresh in the background. The current entry will be used until the entry has been refreshed. - documentation for Caffeine's refresh feature: https://github.com/ben-manes/caffeine/wiki/Refresh * Address review comments
5 tasks
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
refreshAfterWritewill never expire entries. After the given time, the next request to the entry willtrigger a refresh in the background. The current entry will be used until the entry has been refreshed.
Modifications
CACHE_REFRESH_TIME_MILLIS * 2