Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: PartitionedConsumer support queueSize 1 #149

Merged
merged 1 commit into from
Dec 19, 2016

Conversation

rdhabalia
Copy link
Contributor

Motivation

#146 PartitionedConsumer with receiverQueueSize=1 initializes receiverQueue with type of ArrayBlockingQueue which can't consume messages from multiple partitions. Therefore, minimum size of partitioned-consumer's receiverQueue should be: Number of partitions in the topic.

Result

It can support partitioned-consumer with queue-size 1.

@rdhabalia rdhabalia added the type/bug The PR fixed a bug or issue reported a bug label Dec 19, 2016
@rdhabalia rdhabalia added this to the 1.16 milestone Dec 19, 2016
@rdhabalia rdhabalia self-assigned this Dec 19, 2016
@yahoocla
Copy link

CLA is valid!

2 similar comments
@yahoocla
Copy link

CLA is valid!

@yahoocla
Copy link

CLA is valid!

Copy link
Contributor

@merlimat merlimat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rdhabalia rdhabalia merged commit e83647a into apache:master Dec 19, 2016
@rdhabalia rdhabalia deleted the par_queue branch January 23, 2017 22:04
sijie pushed a commit to sijie/pulsar that referenced this pull request Mar 4, 2018
hangc0276 pushed a commit to hangc0276/pulsar that referenced this pull request May 26, 2021
* add ssl config SSL_CLIENT_AUTH_CONFIG: ssl.client.auth support

* change docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants