Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fair message consumption from all partitions in partitioned-cons… #158

Merged
merged 1 commit into from
Jan 4, 2017

Conversation

rdhabalia
Copy link
Contributor

@rdhabalia rdhabalia commented Jan 3, 2017

…umer

Motivation

Based on #153 (creating patch to branch-1.15) : Partitioned-consumer may not fairly consume messages from consumers added into pausedConsumers list until client clean-up queue up to sharedQueueResumeThreshold by receiving messages from the queue.

Modifications

consume from pausedConsumers when queue has space to add message.

Result

All partitioned-consumers will have fair chance to consume messages.

@rdhabalia rdhabalia added type/bug The PR fixed a bug or issue reported a bug area/client labels Jan 3, 2017
@rdhabalia rdhabalia self-assigned this Jan 3, 2017
@yahoocla
Copy link

yahoocla commented Jan 3, 2017

CLA is valid!

3 similar comments
@yahoocla
Copy link

yahoocla commented Jan 3, 2017

CLA is valid!

@yahoocla
Copy link

yahoocla commented Jan 3, 2017

CLA is valid!

@yahoocla
Copy link

yahoocla commented Jan 3, 2017

CLA is valid!

@rdhabalia rdhabalia merged commit 171121f into apache:branch-1.15 Jan 4, 2017
@rdhabalia rdhabalia deleted the 1.15.5 branch January 23, 2017 22:09
hrsakai pushed a commit to hrsakai/pulsar that referenced this pull request Dec 10, 2020
* Topic reader implementation

* Fixed formatting

* Fixed function name

* Fixed the HasNext()

* Fixed formatting stuff

* Fixed queue draining on reconnection

* Removed space

* Fixed deadlock on start

* Added reader example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/client type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants