Safely stop(close replication-producer) and remove replicator #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA is valid! |
1 similar comment
|
CLA is valid! |
rdhabalia
force-pushed
the
replicator
branch
2 times, most recently
from
0f09588
to
d81c0b3
Compare
saandrews
approved these changes
Jan 4, 2017
| POLICY_UPDATE_FAILURE_RETRY_TIME_SECONDS, th); | ||
| brokerService.executor().schedule(this::checkReplication, POLICY_UPDATE_FAILURE_RETRY_TIME_SECONDS, | ||
| TimeUnit.SECONDS); | ||
| result.completeExceptionally(th); |
There was a problem hiding this comment.
We should have a way to prevent this going in loop
sijie
pushed a commit
to sijie/pulsar
that referenced
this pull request
Mar 4, 2018
* Remove logic of supported types since serde is now exposed to the user * Fix test
hrsakai
pushed a commit
to hrsakai/pulsar
that referenced
this pull request
Dec 10, 2020
We should error on the side of readability in code base so we don't need the maligned lint flag.
hangc0276
pushed a commit
to hangc0276/pulsar
that referenced
this pull request
May 26, 2021
Co-authored-by: dockerzhang(张超) <dockerzhang@tencent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Based on #152 (creating patch to branch-1.15) - Safely close replication-producer while disconnecting replicator
Modifications
Result