Support url/uri encoding of topic-name for http-request #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdhabalia
added
the
type/enhancement
|
CLA is valid! |
1 similar comment
|
CLA is valid! |
saandrews
approved these changes
Jan 3, 2017
sijie
added a commit
to sijie/pulsar
that referenced
this pull request
Mar 4, 2018
hrsakai
pushed a commit
to hrsakai/pulsar
that referenced
this pull request
Dec 10, 2020
* Set delay delivery when publishing a message * Fixed indentations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Based on #148 (creating patch on branch-1.15): Broker has lookup and admin REST-api on top of JAX-RS which doesn't follow urlencoding spec while decoding query-param.
application/x-www-form-urlencoded uses + and properly encoded URIs use %20. So, if client sends request with url-encoded query-param (topicName) then broker may not decode it properly due to jax-rs limitation. Therefore, broker should use url-decoder which can handle decoding properly. ( both+and%20can be decoded into space)Modifications
Take encoded topic-name query-param from the http-request and decodes it using url-encoder.
Result
Broker can support both url/uri encoded topic-name request (lookup and admin rest-api).