Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix consumer redelivery should not clear availablePermits #170

Merged
merged 1 commit into from
Jan 20, 2017
Merged

Fix consumer redelivery should not clear availablePermits #170

merged 1 commit into from
Jan 20, 2017

Conversation

rdhabalia
Copy link
Contributor

Motivation

For non-shared consumer: redeliverUnacknowledgedMessages() of consumer is clearing out the availablePermits which causes consumer to stop consuming messages from broker.

Modifications

consumer should increase availablePermits with number of expired messages from incomingMessages queue and sends more permits to broker if availablePermits reaches to defined threshold.

Result

Consumer will not stuck while receiving messages due to redeliverUnacknowledgedMessages().

@rdhabalia rdhabalia added the type/bug The PR fixed a bug or issue reported a bug label Jan 20, 2017
@rdhabalia rdhabalia added this to the 1.16 milestone Jan 20, 2017
@rdhabalia rdhabalia self-assigned this Jan 20, 2017
@rdhabalia rdhabalia mentioned this pull request Jan 20, 2017
Merged
merlimat
merlimat approved these changes Jan 20, 2017
View reviewed changes
Copy link
Contributor

@merlimat merlimat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rdhabalia rdhabalia merged commit e61acc1 into apache:master Jan 20, 2017
@rdhabalia rdhabalia mentioned this pull request Apr 24, 2017
Closed
@rdhabalia rdhabalia deleted the permits-stuck branch June 21, 2017 18:55
sijie pushed a commit to sijie/pulsar that referenced this pull request Mar 4, 2018
@srkukarni @sijie
Allow two types of input. (apache#170)
edbae3c 
1) one with DefaultSerDe
2) one with custom SerDe
hrsakai pushed a commit to hrsakai/pulsar that referenced this pull request Dec 10, 2020
@wolfstudy @sijie
Enable Github Action CI (apache#170)
9b739cf 
Signed-off-by: xiaolong.ran <rxl@apache.org>

Master Issue: apache#169 

### Modifications

- Replace Apache Jenkins with Github Action CI
@xiaotongwang1 xiaotongwang1 mentioned this pull request Aug 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merlimat merlimat merlimat approved these changes

Assignees

@rdhabalia rdhabalia

Labels
type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Milestone
1.16
Development

Successfully merging this pull request may close these issues.
2 participants
@rdhabalia @merlimat