Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix][txn] Correct the prompt message #17009

Merged
merged 2 commits into from
Dec 22, 2022
Merged

[fix][txn] Correct the prompt message #17009

merged 2 commits into from
Dec 22, 2022

Conversation

thetumbled
Copy link
Member

Motivation

the prompt message is wrong.

Modifications

change the prompted message.

@codelipenghui codelipenghui added this to the 2.12.0 milestone Aug 13, 2022
@github-actions
Copy link

@thetumbled Please provide a correct documentation label for your PR.
Instructions see Pulsar Documentation Label Guide.

@codelipenghui codelipenghui changed the title Correct the prompt message [fix][transaction] Correct the prompt message Aug 13, 2022
@github-actions
Copy link

@thetumbled Please provide a correct documentation label for your PR.
Instructions see Pulsar Documentation Label Guide.

@tisonkun tisonkun mentioned this pull request Aug 13, 2022
Merged
Jason918
Jason918 approved these changes Aug 27, 2022
View reviewed changes
Copy link
Contributor

@Jason918 Jason918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jason918
Copy link
Contributor

/pulsarbot run-failure-checks

@github-actions
Copy link

github-actions bot commented Oct 5, 2022

The pr had no activity for 30 days, mark with Stale label.

@github-actions github-actions bot added the Stale label Oct 5, 2022
@Jason918 Jason918 closed this Nov 2, 2022
@Jason918 Jason918 reopened this Nov 2, 2022
@Jason918 Jason918 added doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels Nov 2, 2022
@github-actions github-actions bot added doc-label-missing and removed doc-not-needed Your PR changes do not impact docs labels Nov 2, 2022
@github-actions
Copy link

github-actions bot commented Nov 2, 2022

@thetumbled Please add the following content to your PR description and select a checkbox:

- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->

@codecov-commenter
Copy link

codecov-commenter commented Nov 2, 2022 •
edited
Loading

Codecov Report

Merging #17009 (3645140) into master (08591d9) will decrease coverage by 2.76%.
The diff coverage is 10.63%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #17009      +/-   ##
============================================
- Coverage     49.85%   47.08%   -2.77%     
- Complexity     8658    10576    +1918     
============================================
  Files           500      709     +209     
  Lines         54930    69423   +14493     
  Branches       5867     7448    +1581     
============================================
+ Hits          27386    32689    +5303     
- Misses        24464    33042    +8578     
- Partials       3080     3692     +612
Flag Coverage Δ
unittests 47.08% <10.63%> (-2.77%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...g/apache/pulsar/broker/admin/impl/TenantsBase.java 96.45% <ø> (ø)
...he/pulsar/broker/admin/v2/NonPersistentTopics.java 62.03% <ø> (ø)
...pache/pulsar/broker/admin/v2/PersistentTopics.java 74.53% <ø> (+2.84%) ⬆️
...rg/apache/pulsar/broker/delayed/bucket/Bucket.java 0.00% <0.00%> (ø)
...r/delayed/bucket/BucketDelayedDeliveryTracker.java 0.00% <0.00%> (ø)
.../pulsar/broker/delayed/bucket/ImmutableBucket.java 0.00% <0.00%> (ø)
...g/apache/pulsar/broker/lookup/TopicLookupBase.java 56.89% <ø> (+6.05%) ⬆️
...nsaction/pendingack/impl/PendingAckHandleImpl.java 51.15% <0.00%> (ø)
...rg/apache/pulsar/broker/web/PulsarWebResource.java 58.34% <ø> (+2.68%) ⬆️
...va/org/apache/pulsar/broker/service/ServerCnx.java 48.84% <33.33%> (+1.03%) ⬆️
... and 259 more

@github-actions github-actions bot removed the Stale label Nov 3, 2022
@codelipenghui codelipenghui added doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels Nov 11, 2022
@github-actions github-actions bot added doc-label-missing and removed doc-not-needed Your PR changes do not impact docs labels Nov 11, 2022
@congbobo184
Copy link
Contributor

@thetumbled hi, I move this PR to release/2.9.5, if you have any questions, please ping me. thanks.

@thetumbled
Copy link
Member Author

@thetumbled hi, I move this PR to release/2.9.5, if you have any questions, please ping me. thanks.

Changes have been approved by reviewers. could you merge it? thanks.

@github-actions
Copy link

The pr had no activity for 30 days, mark with Stale label.

@github-actions github-actions bot added the Stale label Dec 22, 2022
@RobertIndie
Copy link
Member

/pulsarbot run-failure-checks

@congbobo184 congbobo184 added doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels Dec 22, 2022
@github-actions github-actions bot added doc-label-missing and removed doc-not-needed Your PR changes do not impact docs labels Dec 22, 2022
@congbobo184
Copy link
Contributor

@thetumbled hi, could you please merge the apache/master branch, seem the test can't rerun

@thetumbled
Copy link
Member Author

@thetumbled hi, could you please merge the apache/master branch, seem the test can't rerun

done.

@nicoloboschi nicoloboschi merged commit 41edd2e into apache:master Dec 22, 2022
liangyepianzhou pushed a commit that referenced this pull request Feb 6, 2023
@thetumbled @liangyepianzhou
[fix][txn] Correct the prompt message (#17009)
45678b8 
Co-authored-by: fengwenzhi <fengwenzhi.max@bigo.sg>
(cherry picked from commit 41edd2e)
Technoboy- pushed a commit that referenced this pull request Feb 7, 2023
@thetumbled @Technoboy-
[fix][txn] Correct the prompt message (#17009)
7f7d931 
Co-authored-by: fengwenzhi <fengwenzhi.max@bigo.sg>
coderzc pushed a commit that referenced this pull request Feb 27, 2023
@thetumbled @coderzc
[fix][txn] Correct the prompt message (#17009)
fa0895c 
Co-authored-by: fengwenzhi <fengwenzhi.max@bigo.sg>
(cherry picked from commit 41edd2e)
@coderzc coderzc added the cherry-picked/branch-2.9 Archived: 2.9 is end of life label Feb 27, 2023
nicoloboschi pushed a commit to datastax/pulsar that referenced this pull request Feb 28, 2023
@thetumbled @nicoloboschi
[fix][txn] Correct the prompt message (apache#17009)
7e95b66 
Co-authored-by: fengwenzhi <fengwenzhi.max@bigo.sg>
(cherry picked from commit 41edd2e)
(cherry picked from commit 45678b8)
Annavar-satish pushed a commit to pandio-com/pulsar that referenced this pull request Mar 6, 2023
@thetumbled
[fix][txn] Correct the prompt message (apache#17009)
9d39687 
Co-authored-by: fengwenzhi <fengwenzhi.max@bigo.sg>
(cherry picked from commit 41edd2e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congbobo184 congbobo184 congbobo184 approved these changes

@nicoloboschi nicoloboschi nicoloboschi approved these changes

@RobertIndie RobertIndie RobertIndie approved these changes

@codelipenghui codelipenghui codelipenghui approved these changes

@Jason918 Jason918 Jason918 approved these changes

Assignees

@thetumbled thetumbled

Labels
area/transaction cherry-picked/branch-2.9 Archived: 2.9 is end of life cherry-picked/branch-2.10 cherry-picked/branch-2.11 doc-label-missing release/2.9.5 release/2.10.4 release/2.11.1 Stale
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
10 participants
@thetumbled @Jason918 @codecov-commenter @congbobo184 @RobertIndie @codelipenghui @nicoloboschi @Technoboy- @coderzc @liangyepianzhou