[feat][broker]PIP-180: ShadowTopic - Part I - Refactor replicator for ShadowReplicator #17150
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
ShadowReplicator is part of PIP-180 (#16153).
ShadowReplicator and GeoReplicator(which implemented by
PersistentReplicator
) share most of the logics.This PR refactor replicators so that shadow replicator can extends from
PersistentReplicator
in the next parts of PIP-180.And moves the geo-replication related logics to
GeoPersistentReplicator
.Modifications
AbstractReplicator
, for GeoReplicator : remoteTopic == localTopic, for ShadowReplicator: localCluster == remoteCluster.AbstractReplicator#replicatorId
to help simplify logging info.log.info("[{}][{} -> {}],...",topicName, localCluster, remoteCluster,...)
tolog.info("[{}],...",replicatorId,...)
Verifying this change
This PR contains no functional change. All the tests about geo-replication can verify this change.
This change is already covered by existing tests, such as ReplicatorTest.
Does this pull request potentially affect one of the following parts:
NO
Documentation
Check the box below or label this PR directly.
Need to update docs?
doc-not-needed
Code refactor.