Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][tiered-storage] Don't cleanup data when offload met Metastore exception #17512

Merged
merged 4 commits into from
Sep 14, 2022

Commits on Sep 8, 2022

  1. [fix][tiered-storage] Don't cleanup data when offload met BadVersion

    ---
    
    *Motivation*
    
    There have two ways that will cause the offload data cleanup. One is met
    offload conflict exception, and another is completeLedgerInfoForOffloaded
    reaches max retry time and throws zookeeper exceptions.
    
    We retry the zookeeper operation on connection loss exception. We should
    be careful about this exception, because we may loss data if the metadata
    update successfully.
    
    When a MetaStore exception happens, we can not make sure the metadata update is
    failed or not. Because we have a retry on the connection loss, it is
    possible to get a BadVersion or other exception after retrying.
    
    So we don't clean up the data if this happens.
    
    *Modification*
    
    - don't delete data if has meta store exception
    zymap authored and Technoboy- committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    945ebac View commit details
    Browse the repository at this point in the history
  2. log error when skip deleting

    zymap authored and Technoboy- committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    23b3af2 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2022

  1. improve logs

    zymap committed Sep 9, 2022
    Configuration menu
    Copy the full SHA
    ff1eac4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    49bba36 View commit details
    Browse the repository at this point in the history