Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[improve][build] use SLASHSTAR_STYLE for licenses in Java files #18177

Merged
merged 2 commits into from
Oct 25, 2022
Merged

[improve][build] use SLASHSTAR_STYLE for licenses in Java files #18177

merged 2 commits into from
Oct 25, 2022

Conversation

tisonkun
Copy link
Member

@tisonkun tisonkun commented Oct 24, 2022 •
edited
Loading

This supersedes #17508.

See also https://lists.apache.org/thread/gwy3ycgsq24r784mk3yv6cbppmbfxgjd.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: tisonkun#9

@tisonkun
[improve][build] use SLASHSTAR_STYLE for licenses in Java files
c15cc1d 
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun
run mvn initialize license:format
7dfb11c 
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun
Copy link
Member Author

cc @BewareMyPower @RobertIndie

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Oct 24, 2022
@tisonkun tisonkun mentioned this pull request Oct 24, 2022
Closed
@tisonkun
Copy link
Member Author

/pulsarbot run-failure-checks

@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2022 •
edited
Loading

Codecov Report

Merging #18177 (7dfb11c) into master (6c65ca0) will increase coverage by 15.70%.
The diff coverage is 0.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             master   #18177       +/-   ##
=============================================
+ Coverage     34.91%   50.62%   +15.70%     
- Complexity     5707     8686     +2979     
=============================================
  Files           607      612        +5     
  Lines         53396    53579      +183     
  Branches       5712     5742       +30     
=============================================
+ Hits          18644    27125     +8481     
+ Misses        32119    23403     -8716     
- Partials       2633     3051      +418
Flag Coverage Δ
unittests 50.62% <0.00%> (+15.70%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...in/java/org/apache/pulsar/PulsarBrokerStarter.java 0.00% <ø> (ø)
.../org/apache/pulsar/PulsarClusterMetadataSetup.java 0.00% <ø> (ø)
...g/apache/pulsar/PulsarClusterMetadataTeardown.java 0.00% <ø> (ø)
...org/apache/pulsar/PulsarInitialNamespaceSetup.java 0.00% <ø> (ø)
.../main/java/org/apache/pulsar/PulsarStandalone.java 0.00% <0.00%> (ø)
...ava/org/apache/pulsar/PulsarStandaloneBuilder.java 0.00% <ø> (ø)
...ava/org/apache/pulsar/PulsarStandaloneStarter.java 0.00% <ø> (ø)
...sar/PulsarTransactionCoordinatorMetadataSetup.java 0.00% <ø> (ø)
...n/java/org/apache/pulsar/PulsarVersionStarter.java 0.00% <ø> (ø)
...java/org/apache/pulsar/proxy/stats/TopicStats.java 58.82% <0.00%> (-41.18%) ⬇️
... and 204 more

@tisonkun
Copy link
Member Author

/pulsarbot rerun-failure-checks

1 similar comment
@tisonkun
Copy link
Member Author

/pulsarbot rerun-failure-checks

@tisonkun
Copy link
Member Author

ping @BewareMyPower @RobertIndie @nicoloboschi @eolivelli @Jason918 tests passed. Although I can always reapply the formatting step, I hope with can have a timely review stage :)

@BewareMyPower BewareMyPower merged commit 82237d3 into apache:master Oct 25, 2022
@tisonkun
Copy link
Member Author

Thanks for merging this patch. Be aware that we may suffer a period that new patches introduce regression for the JAVADOC_STYLE license header because we don't require the patch to be merged must be up-to-date. But the overall situation should converge.

@tisonkun tisonkun deleted the SLASHSTAR_STYLE-license branch October 25, 2022 06:00
dlg99 added a commit to dlg99/pulsar that referenced this pull request Oct 25, 2022
@dlg99
fix license issue: coupleof files without changes in format apache#18177
78b899e
@Technoboy- Technoboy- added this to the 2.12.0 milestone Nov 14, 2022
@mattisonchao
Copy link
Member

Hi, @tisonkun
I'm not sure If this change is acceptable for PMCs or needs to vote on. But there is some trouble with cherry-picking new changes to the previous branch.
I'm wondering if we have a good method to resolve the conflict with the previous branch. maybe mvn initialize license:format can work properly? I'm not sure...
Anyway, thanks a lot for your contribution, I hope you can answer my question though, thanks!

@tisonkun
Copy link
Member Author

@mattisonchao This is not a breaking change from a user perspective. Thus, I don't initialize a formal vote.

I made several discussions on the dev@ list:

... and follow the common lazy consensus principle.

To resolve your issues, either run mvn initialize license:format on the failure PR, or manually append * for new files when cherry-picking.

The new style is started from 2.12 or 2.11 and the whole style will converge finally.

@mattisonchao
Copy link
Member

Ok, Got it. thanks!

This was referenced Dec 24, 2022
Closed
Merged
hezhangjian added a commit to apache/bookkeeper that referenced this pull request Dec 27, 2022
@hezhangjian
unify SLASHSTAR_STYLE for licenses in Java files (#3717)
405e72a 
### Motivation
Use SLASHSTAR_STYLE to avoid formatting unnecessary changes.

See also: 
- apache/pulsar#18177
- https://lists.apache.org/thread/gwy3ycgsq24r784mk3yv6cbppmbfxgjd

### Changes
Use SLASHSTAR_STYLE instead of javadoc style.
@hezhangjian hezhangjian mentioned this pull request Jan 17, 2023
Merged
hezhangjian added a commit to apache/bookkeeper that referenced this pull request Jan 28, 2023
@hezhangjian
unify SLASHSTAR_STYLE for licenses in Java files (#3741)
e763608 
### Motivation
Use SLASHSTAR_STYLE to avoid formatting unnecessary changes.

See also: 
- #3717
- apache/pulsar#18177
- https://lists.apache.org/thread/gwy3ycgsq24r784mk3yv6cbppmbfxgjd

### Changes
Use SLASHSTAR_STYLE instead of javadoc style.
yaalsn pushed a commit to yaalsn/bookkeeper that referenced this pull request Jan 30, 2023
@hezhangjian @yaalsn
unify SLASHSTAR_STYLE for licenses in Java files (apache#3717)
d8ba79c 
### Motivation
Use SLASHSTAR_STYLE to avoid formatting unnecessary changes.

See also: 
- apache/pulsar#18177
- https://lists.apache.org/thread/gwy3ycgsq24r784mk3yv6cbppmbfxgjd

### Changes
Use SLASHSTAR_STYLE instead of javadoc style.
yaalsn pushed a commit to yaalsn/bookkeeper that referenced this pull request Jan 30, 2023
@hezhangjian @yaalsn
unify SLASHSTAR_STYLE for licenses in Java files (apache#3741)
2cf9973 
### Motivation
Use SLASHSTAR_STYLE to avoid formatting unnecessary changes.

See also: 
- apache#3717
- apache/pulsar#18177
- https://lists.apache.org/thread/gwy3ycgsq24r784mk3yv6cbppmbfxgjd

### Changes
Use SLASHSTAR_STYLE instead of javadoc style.
Ghatage pushed a commit to sijie/bookkeeper that referenced this pull request Jul 12, 2024
@hezhangjian
unify SLASHSTAR_STYLE for licenses in Java files (apache#3717)
004a726 
### Motivation
Use SLASHSTAR_STYLE to avoid formatting unnecessary changes.

See also: 
- apache/pulsar#18177
- https://lists.apache.org/thread/gwy3ycgsq24r784mk3yv6cbppmbfxgjd

### Changes
Use SLASHSTAR_STYLE instead of javadoc style.
Ghatage pushed a commit to sijie/bookkeeper that referenced this pull request Jul 12, 2024
@hezhangjian
unify SLASHSTAR_STYLE for licenses in Java files (apache#3741)
3c5e34d 
### Motivation
Use SLASHSTAR_STYLE to avoid formatting unnecessary changes.

See also: 
- apache#3717
- apache/pulsar#18177
- https://lists.apache.org/thread/gwy3ycgsq24r784mk3yv6cbppmbfxgjd

### Changes
Use SLASHSTAR_STYLE instead of javadoc style.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BewareMyPower BewareMyPower BewareMyPower approved these changes

@RobertIndie RobertIndie RobertIndie approved these changes

@nicoloboschi nicoloboschi Awaiting requested review from nicoloboschi

@Jason918 Jason918 Awaiting requested review from Jason918

@eolivelli eolivelli Awaiting requested review from eolivelli

Assignees

@tisonkun tisonkun

Labels
doc-not-needed Your PR changes do not impact docs ready-to-test
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
6 participants
@tisonkun @codecov-commenter @mattisonchao @RobertIndie @BewareMyPower @Technoboy-