Configure split-bundle task interval different than loadReportGenerationTask-interval

[rdhabalia]

Motivation

If loadBalancerReportUpdateMaxIntervalMinutes is same as loadBalancerNamespaceBundleSplitIntervalMinutes (by default = 15 mins) then splitBundleTask may read stale List of Bundles and it will end up splitting invalid bundles which cause #172

Modifications

Keep different interval value for : loadBalancerReportUpdateMaxIntervalMinutes and loadBalancerNamespaceBundleSplitIntervalMinutes, to avoid stale-read of bundle data.

Result

It will fix #172

[merlimat]

Is it possible to make it working for any config values? I haven't checked the code there but maybe there's a way to prevent both tasks from running st the same time.

[rdhabalia]

Is it possible to make it working for any config values? I haven't checked the code there but maybe there's a way to prevent both tasks from running st the same time.

I think we can remove splitTaskConfiguration(loadBalancerNamespaceBundleSplitIntervalMinutes) instead keep its value as loadBalancerReportUpdateMaxIntervalMinutes + 5 because we have to make sure that splitBundle should run only after loadReport gets updated, otherwise there could be a possibility to read stale loadReport value.
Any thought?

[merlimat]

Wouldn't it be easier to chain the 2 tasks in the same thread? Compute the load report and then check for bundles to be split.

Though, my concern is that the exception in #172 could happen anyway, cause a bundle could be unloaded after the report was generated. We should just ignore that bundle and move on at that point.

[rdhabalia]

Make sense. I will make the change.

[rdhabalia]

updated PR by merging loadReportGeneration and splitBundleTask.

[merlimat]

👍

[merlimat]

@rdhabalia Anything else for 1.16 ?