Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][client] Remove JsonIgnore on ProducerConfigurationData.encryptionKeys #18351

Merged
merged 1 commit into from
Nov 10, 2022

Conversation

cbornet
Copy link
Contributor

@cbornet cbornet commented Nov 5, 2022

Fixes #7579

Motivation

encryptionKeys is public data (the name of the keys to use, not the keys themselves) so there's no reason to hide it.
And it's a Set<String> so it serializes/deserializes fine with Jackson.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: cbornet#8

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Nov 5, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 5, 2022

Codecov Report

Merging #18351 (f9802e3) into master (a2c1534) will decrease coverage by 3.41%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #18351      +/-   ##
============================================
- Coverage     51.47%   48.06%   -3.42%     
- Complexity     7410     9387    +1977     
============================================
  Files           405      613     +208     
  Lines         44012    58392   +14380     
  Branches       4517     6088    +1571     
============================================
+ Hits          22656    28065    +5409     
- Misses        18935    27305    +8370     
- Partials       2421     3022     +601     
Flag Coverage Δ
unittests 48.06% <ø> (-3.42%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ar/client/impl/conf/ProducerConfigurationData.java 84.70% <ø> (ø)
...oker/service/schema/SchemaRegistryServiceImpl.java 59.45% <0.00%> (-4.21%) ⬇️
...ava/org/apache/pulsar/broker/service/Consumer.java 69.68% <0.00%> (-2.13%) ⬇️
...ervice/AbstractDispatcherSingleActiveConsumer.java 69.15% <0.00%> (-1.87%) ⬇️
...apache/pulsar/proxy/server/LookupProxyHandler.java 56.46% <0.00%> (-1.73%) ⬇️
...he/pulsar/broker/admin/v2/NonPersistentTopics.java 60.64% <0.00%> (-1.39%) ⬇️
...a/org/apache/pulsar/client/impl/RawReaderImpl.java 83.90% <0.00%> (-1.15%) ⬇️
...rg/apache/pulsar/broker/web/PulsarWebResource.java 57.20% <0.00%> (-1.09%) ⬇️
...ice/persistent/PersistentMessageExpiryMonitor.java 43.75% <0.00%> (-1.05%) ⬇️
...tent/PersistentDispatcherSingleActiveConsumer.java 55.17% <0.00%> (-0.95%) ⬇️
... and 230 more

@AnonHxy AnonHxy added this to the 2.12.0 milestone Nov 10, 2022
@AnonHxy AnonHxy merged commit 0650676 into apache:master Nov 10, 2022
@cbornet cbornet deleted the enckeys branch December 6, 2022 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-not-needed Your PR changes do not impact docs ready-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make encryptionKey property configurable through producer configurations using loadConf method
4 participants