Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cleanup][broker] Add missing @Test annotation #18528

Merged
merged 1 commit into from
Nov 18, 2022

Conversation

michaeljmarshall
Copy link
Member

Motivation

#18416 added a new test and missed the @Test annotation.

Modifications

Add the @Test annotation.

Verifying this change

This PR includes a "new" test.

Documentation

  • doc-not-needed

@michaeljmarshall michaeljmarshall added type/cleanup Code or doc cleanups e.g. remove the outdated documentation or remove the code no longer in use area/broker doc-not-needed Your PR changes do not impact docs ready-to-test labels Nov 18, 2022
@michaeljmarshall michaeljmarshall added this to the 2.12.0 milestone Nov 18, 2022
@michaeljmarshall michaeljmarshall self-assigned this Nov 18, 2022
@nodece nodece requested a review from tisonkun November 18, 2022 04:02
@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2022

Codecov Report

Merging #18528 (2dd599e) into master (aeb4503) will increase coverage by 14.31%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             master   #18528       +/-   ##
=============================================
+ Coverage     31.39%   45.70%   +14.31%     
- Complexity     6651    10095     +3444     
=============================================
  Files           697      697               
  Lines         68015    68016        +1     
  Branches       7285     7285               
=============================================
+ Hits          21353    31087     +9734     
+ Misses        43667    33371    -10296     
- Partials       2995     3558      +563     
Flag Coverage Δ
unittests 45.70% <100.00%> (+14.31%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...che/bookkeeper/mledger/impl/ManagedLedgerImpl.java 53.95% <100.00%> (+0.10%) ⬆️
...apache/pulsar/proxy/server/LookupProxyHandler.java 57.75% <0.00%> (-0.44%) ⬇️
...che/bookkeeper/mledger/impl/ManagedCursorImpl.java 37.11% <0.00%> (-0.06%) ⬇️
.../apache/pulsar/broker/namespace/LookupOptions.java 87.50% <0.00%> (ø)
.../org/apache/pulsar/client/impl/ConnectionPool.java 38.46% <0.00%> (+1.02%) ⬆️
.../apache/pulsar/common/naming/NamespaceBundles.java 69.87% <0.00%> (+1.20%) ⬆️
...roker/systopic/TopicPoliciesSystemTopicClient.java 57.14% <0.00%> (+1.29%) ⬆️
...ersistentStickyKeyDispatcherMultipleConsumers.java 39.90% <0.00%> (+1.44%) ⬆️
.../java/org/apache/pulsar/broker/web/WebService.java 74.86% <0.00%> (+2.13%) ⬆️
... and 148 more

@tisonkun tisonkun merged commit 154fb8b into apache:master Nov 18, 2022
@michaeljmarshall michaeljmarshall deleted the add-test-annotation branch November 18, 2022 16:28
lifepuzzlefun pushed a commit to lifepuzzlefun/pulsar that referenced this pull request Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/broker doc-not-needed Your PR changes do not impact docs ready-to-test type/cleanup Code or doc cleanups e.g. remove the outdated documentation or remove the code no longer in use
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants