[improve][test] broker: remove prometheus tests from flaky group #18554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The broker PromtheusMetricsTest should be reliable enough to run in the main broker test group. This will help prevent future merges from accidentally breaking the broker metrics. Signed-off-by: Paul Gier <paul.gier@datastax.com>
pgier
changed the title
nodece
approved these changes
Nov 21, 2022
Codecov Report
@@ Coverage Diff @@
## master #18554 +/- ##
============================================
+ Coverage 47.50% 47.92% +0.41%
+ Complexity 10505 7866 -2639
============================================
Files 698 463 -235
Lines 67984 51345 -16639
Branches 7272 5458 -1814
============================================
- Hits 32297 24607 -7690
+ Misses 32112 23907 -8205
+ Partials 3575 2831 -744
Flags with carried forward coverage won't be shown. Click here to find out more.
|
tisonkun
approved these changes
Nov 21, 2022
|
Merging... Thanks for taking care of tests @pgier! |
lifepuzzlefun
pushed a commit
to lifepuzzlefun/pulsar
that referenced
this pull request
Dec 9, 2022
Signed-off-by: Paul Gier <paul.gier@datastax.com>
lifepuzzlefun
pushed a commit
to lifepuzzlefun/pulsar
that referenced
this pull request
Jan 10, 2023
Signed-off-by: Paul Gier <paul.gier@datastax.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The broker PromtheusMetricsTest should be reliable enough to run in the main broker test group. This will help prevent future merges from accidentally breaking the broker metrics.
Signed-off-by: Paul Gier paul.gier@datastax.com
Motivation
This just moves some tests out of the flaky group and into the broker group. This will help ensure that these tests pass before any new code changes.
Modifications
Changed the test group from flaky to broker for the prometheus metrics test.
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: pgier#4