-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][test] flaky test testCanRecoverConsumptionWhenLiftMaxUnAckedMessagesRestriction
#18726
Conversation
Codecov Report
@@ Coverage Diff @@
## master #18726 +/- ##
============================================
- Coverage 47.74% 46.95% -0.79%
+ Complexity 10623 10552 -71
============================================
Files 703 703
Lines 68828 68828
Branches 7381 7381
============================================
- Hits 32861 32319 -542
- Misses 32307 32874 +567
+ Partials 3660 3635 -25
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/pulsarbot rerun-failure-checks |
1 similar comment
/pulsarbot rerun-failure-checks |
/pulsarbot rerun-failure-checks |
2 similar comments
/pulsarbot rerun-failure-checks |
/pulsarbot rerun-failure-checks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This pr is ready to merge ^_^ |
…ssagesRestriction` (apache#18726)
…ssagesRestriction` (apache#18726)
…ssagesRestriction` (apache#18726)
…ssagesRestriction` (apache#18726) (cherry picked from commit 2d205c9) Signed-off-by: Zixuan Liu <nodeces@gmail.com>
* [fix][broker] Fix incorrect unack msk count when dup ack a message (apache#20990) (cherry picked from commit 4facdad) Signed-off-by: Zixuan Liu <nodeces@gmail.com> * [fix][test] flaky test `testCanRecoverConsumptionWhenLiftMaxUnAckedMessagesRestriction` (apache#18726) (cherry picked from commit 2d205c9) Signed-off-by: Zixuan Liu <nodeces@gmail.com> --------- Co-authored-by: Jiwei Guo <technoboy@apache.org> Co-authored-by: labuladong <labuladong@foxmail.com>
…ssagesRestriction` (apache#18726) (cherry picked from commit 2d205c9) Signed-off-by: Zixuan Liu <nodeces@gmail.com>
…ssagesRestriction` (apache#18726) (cherry picked from commit 2d205c9)
* [fix][broker] Fix incorrect unack msk count when dup ack a message (apache#20990) (cherry picked from commit 4facdad) Signed-off-by: Zixuan Liu <nodeces@gmail.com> * [fix][test] flaky test `testCanRecoverConsumptionWhenLiftMaxUnAckedMessagesRestriction` (apache#18726) (cherry picked from commit 2d205c9) Signed-off-by: Zixuan Liu <nodeces@gmail.com> --------- Co-authored-by: Jiwei Guo <technoboy@apache.org> Co-authored-by: labuladong <labuladong@foxmail.com>
Fixes #18617
Modifications
The reason for
Awaitility
timeout:pulsar/pulsar-broker/src/test/java/org/apache/pulsar/client/impl/KeySharedSubscriptionTest.java
Lines 142 to 155 in 3df506d
The producer didn't set a
key
for msg, so even if there are 3key_shared
consumers, there is only 1 consumer to receive messages.Then this consumer will sync receive and sync ack 1000 messages in 10 - 5 = 5 seconds, a little hurry:
pulsar/pulsar-broker/src/test/java/org/apache/pulsar/client/impl/KeySharedSubscriptionTest.java
Lines 172 to 177 in 3df506d
Solution:
Construct keys for messages, and ensure all 3 consumers can handle messages.
Give more time to wait for all consumers to handle messages.
Verifying this change
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: labuladong#15