[fix][broker] Fix thread safety issue in info-internal admin api for partitioned topics #19021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…partitioned topics - the resulting map isn't thread safe in PartitionedManagedLedgerInfo - it's better to refactor the logic to compose the results after the futures have completed
codelipenghui
approved these changes
Dec 22, 2022
Technoboy-
reviewed
Dec 22, 2022
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
Outdated
Show resolved
Hide resolved
|
/pulsarbot rerun-failure-checks |
Codecov Report
@@ Coverage Diff @@
## master #19021 +/- ##
============================================
+ Coverage 49.85% 50.49% +0.63%
- Complexity 8658 8673 +15
============================================
Files 500 500
Lines 54930 54987 +57
Branches 5867 5875 +8
============================================
+ Hits 27386 27764 +378
+ Misses 24464 24090 -374
- Partials 3080 3133 +53
Flags with carried forward coverage won't be shown. Click here to find out more.
|
michaeljmarshall
approved these changes
Dec 22, 2022
Technoboy-
approved these changes
Dec 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Modifications
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: lhotari#119