[fix][client] Prevent DNS reverse lookup when physical address is an IP address #19028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BewareMyPower
approved these changes
Dec 22, 2022
michaeljmarshall
approved these changes
Dec 22, 2022
Codecov Report
@@ Coverage Diff @@
## master #19028 +/- ##
============================================
- Coverage 49.85% 45.35% -4.50%
- Complexity 8658 10898 +2240
============================================
Files 500 769 +269
Lines 54930 74180 +19250
Branches 5867 7981 +2114
============================================
+ Hits 27386 33648 +6262
- Misses 24464 36764 +12300
- Partials 3080 3768 +688
Flags with carried forward coverage won't be shown. Click here to find out more.
|
congbobo184
approved these changes
Dec 23, 2022
nodece
approved these changes
Dec 23, 2022
michaeljmarshall
added
cherry-picked/branch-2.9
|
I cherry picked this change to older branches because it was going to be introduced by #19327. |
michaeljmarshall
added
cherry-picked/branch-2.8
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Feb 28, 2023
…IP address (apache#19028) (cherry picked from commit d8569cd) (cherry picked from commit 5385f3b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
A call to java.net.InetSocketAddress#getHostName will trigger a reverse DNS lookup when the physical address is an IP address. This is not desired since the DNS resolver will be blocking execution.
Modifications
Use java.net.InetSocketAddress#getHostString to use the address passed as input (host string or ip address).
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: lhotari#120