[fix][proxy] Cleanup default collector registry when closing the ProxyServiceStarter

[gaoran10]

Fixes: #19011

Motivation

Related issue #19011.

Most of the tests are all based on the class TestRetrySupport, which supports resetting the broken test environments, the ProxyServiceStarter will register metrics in the default collector registry if we restart the ProxyServiceStarter, it will throw the exception like this.

java.lang.IllegalArgumentException: Failed to register Collector of type Gauge: jvm_memory_direct_bytes_used is already in use by another Collector of type Gauge

Modifications

Clean up the default collector registry when closing the ProxyServiceStarter.

Verifying this change

This change is already covered by existing tests.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

• Dependencies (add or upgrade a dependency)
• The public API
• The schema
• The default values of configurations
• The threading model
• The binary protocol
• The REST endpoints
• The admin CLI options
• The metrics
• Anything that affects deployment

Documentation

• doc
• doc-required
• doc-not-needed
• doc-complete

Matching PR in forked repository

PR in forked repository: gaoran10#20

[codelipenghui]

/pulsarbot run-failure-checks

[codecov-commenter]

Codecov Report

Merging #19062 (9745033) into master (b42aed1) will decrease coverage by 0.21%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master   #19062      +/-   ##
============================================
- Coverage     47.11%   46.90%   -0.22%     
+ Complexity    10595    10588       -7     
============================================
  Files           710      710              
  Lines         69423    69424       +1     
  Branches       7449     7449              
============================================
- Hits          32709    32563     -146     
- Misses        33037    33228     +191     
+ Partials       3677     3633      -44     

Flag	Coverage Δ
unittests	46.90% <100.00%> (-0.22%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...pache/pulsar/proxy/server/ProxyServiceStarter.java	60.92% <100.00%> (+0.26%)	⬆️
...rvice/schema/KeyValueSchemaCompatibilityCheck.java	21.62% <0.00%> (-45.95%)	⬇️
...apache/pulsar/broker/service/TopicListService.java	10.40% <0.00%> (-30.40%)	⬇️
...lsar/broker/loadbalance/impl/ThresholdShedder.java	3.27% <0.00%> (-27.05%)	⬇️
...g/apache/bookkeeper/mledger/util/StatsBuckets.java	43.75% <0.00%> (-16.67%)	⬇️
...pulsar/broker/service/PulsarCommandSenderImpl.java	60.20% <0.00%> (-11.74%)	⬇️
...ookkeeper/mledger/impl/ManagedLedgerMBeanImpl.java	53.17% <0.00%> (-9.53%)	⬇️
...oker/service/nonpersistent/NonPersistentTopic.java	42.02% <0.00%> (-9.44%)	⬇️
...org/apache/pulsar/broker/loadbalance/LoadData.java	58.33% <0.00%> (-8.34%)	⬇️
...ker/resourcegroup/ResourceGroupPublishLimiter.java	31.03% <0.00%> (-8.05%)	⬇️
... and 33 more

[lhotari]

This change has to be reverted or revisited since it's causing a lot of build failures. The issue is #19216.

Counters registered in static field initializers such as

pulsar/pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyService.java

Lines 137 to 138 in accae9f

	static final Counter BYTES_COUNTER = Counter
	.build("pulsar_proxy_binary_bytes", "Counter of proxy bytes").create().register();

won't get re-registered and that's why this change makes another test break.

[lhotari]

I'm working on a revisited change.