-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][doc] Rename LedgerInfo to avoid swagger docs conflict #19087
Conversation
Signed-off-by: tison <wander4096@gmail.com>
2132454
to
c3a056e
Compare
Codecov Report
@@ Coverage Diff @@
## master #19087 +/- ##
============================================
- Coverage 47.46% 47.38% -0.08%
- Complexity 10727 10728 +1
============================================
Files 711 711
Lines 69456 69461 +5
Branches 7452 7453 +1
============================================
- Hits 32964 32915 -49
- Misses 32810 32857 +47
- Partials 3682 3689 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: tison <wander4096@gmail.com>
Do you mean there are two LedgerInfo in the swagger.json? |
Finally there's one, but the field is different because it's randomly generated from |
See apache/pulsar-site@619e9ec.
These two classes conflict in name:
org.apache.pulsar.common.policies.data.ManagedLedgerInternalStats.LedgerInfo
org.apache.bookkeeper.mledger.ManagedLedgerInfo.LedgerInfo
Since the latter one is a public interface while the former one is for internal usage, I tend to rename the former one to deduplicate.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: