Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][ci] Speed up OWASP dependency check in Pulsar CI workflow #20412

Merged
merged 1 commit into from
May 27, 2023

Conversation

lhotari
Copy link
Member

@lhotari lhotari commented May 26, 2023

Motivation

OWASP dependency check within Pulsar CI workflow is really slow.

Modifications

  • speed up check in Pulsar CI workflow
    • don't build artifacts when running dependency check

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

- don't build artifacts when running dependency check
@lhotari lhotari added this to the 3.1.0 milestone May 26, 2023
@lhotari lhotari requested review from tisonkun and nicoloboschi May 26, 2023 19:19
@lhotari lhotari self-assigned this May 26, 2023
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label May 26, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #20412 (24a7eb3) into master (a953027) will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #20412      +/-   ##
============================================
- Coverage     72.95%   72.87%   -0.08%     
+ Complexity    31893    31872      -21     
============================================
  Files          1864     1864              
  Lines        138416   138416              
  Branches      15188    15188              
============================================
- Hits         100976   100866     -110     
- Misses        29440    29530      +90     
- Partials       8000     8020      +20     
Flag Coverage Δ
inttests 24.20% <ø> (-0.01%) ⬇️
systests 24.97% <ø> (-0.02%) ⬇️
unittests 72.16% <ø> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 56 files with indirect coverage changes

@tisonkun tisonkun merged commit aa3bfcd into apache:master May 27, 2023
lhotari added a commit that referenced this pull request May 29, 2023
lhotari added a commit that referenced this pull request May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants