[improve] [broker] Avoid PersistentSubscription.expireMessages logic check backlog twice.
#20416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lifepuzzlefun
changed the title
lifepuzzlefun
changed the title
PersistentSubscription.expireMessages logic check backlog twice.
AnonHxy
approved these changes
May 29, 2023
|
LGTM |
|
Please add the link of PR in forked repository, thanks |
Codecov Report
@@ Coverage Diff @@
## master #20416 +/- ##
============================================
+ Coverage 72.90% 72.93% +0.02%
- Complexity 31864 31897 +33
============================================
Files 1864 1864
Lines 138416 138416
Branches 15188 15188
============================================
+ Hits 100919 100954 +35
+ Misses 29477 29458 -19
+ Partials 8020 8004 -16
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Technoboy-
approved these changes
May 29, 2023
Technoboy-
pushed a commit
to Technoboy-/pulsar
that referenced
this pull request
May 29, 2023
…c check backlog twice. (apache#20416)
Technoboy-
pushed a commit
that referenced
this pull request
May 30, 2023
…c check backlog twice. (#20416)
|
As discussed on the mailing list https://lists.apache.org/thread/w4jzk27qhtosgsz7l9bmhf1t7o9mxjhp, there is no plan to release 2.9.6, so I am going to remove the release/2.9.6 label |
Technoboy-
pushed a commit
that referenced
this pull request
Jul 4, 2023
…c check backlog twice. (#20416)
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 17, 2023
…c check backlog twice. (apache#20416) (cherry picked from commit c9eb6bd)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
PersistentSubscription.expireMessageswill first backlog is zero and if not will check if backlog is below threshold.those two check should be save in variable to avoid check twice.
Modifications
save backlog to variable.
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: