Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix][test] Fix test testThreadSwitchOfZkMetadataStore #20446

Merged
merged 3 commits into from
Jun 1, 2023
Merged

[fix][test] Fix test testThreadSwitchOfZkMetadataStore #20446

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6ae2102
[branch-2.11] [fix] [test]fix test testThreadSwitchOfZkMetadataStore
poorbarcode May 31, 2023
e50085c
[branch-2.11] [fix] [test]fix test testThreadSwitchOfZkMetadataStore
poorbarcode May 31, 2023
a7f7301
remove unnecessary imports
poorbarcode May 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions pulsar-metadata/src/test/java/org/apache/pulsar/metadata/MetadataStoreTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@
import java.util.List;
import java.util.Optional;
import java.util.Set;
import java.util.UUID;
import java.util.concurrent.BlockingQueue;
import java.util.concurrent.CompletableFuture;
import java.util.concurrent.CompletionException;
Expand Down Expand Up @@ -432,10 +431,9 @@ public Object[][] conditionOfSwitchThread(){
@Test(dataProvider = "conditionOfSwitchThread")
public void testThreadSwitchOfZkMetadataStore(boolean hasSynchronizer, boolean enabledBatch) throws Exception {
final String prefix = newKey();
final String metadataStoreName = UUID.randomUUID().toString().replaceAll("-", "");
final String metadataStoreNamePrefix = "metadata-store";
MetadataStoreConfig.MetadataStoreConfigBuilder builder =
MetadataStoreConfig.builder().metadataStoreName(metadataStoreName);
builder.fsyncEnable(false);
MetadataStoreConfig.builder();
builder.batchingEnabled(enabledBatch);
if (!hasSynchronizer) {
builder.synchronizer(null);
Expand All @@ -447,8 +445,8 @@ public void testThreadSwitchOfZkMetadataStore(boolean hasSynchronizer, boolean e
final Runnable verify = () -> {
String currentThreadName = Thread.currentThread().getName();
String errorMessage = String.format("Expect to switch to thread %s, but currently it is thread %s",
metadataStoreName, currentThreadName);
assertTrue(Thread.currentThread().getName().startsWith(metadataStoreName), errorMessage);
metadataStoreNamePrefix, currentThreadName);
assertTrue(Thread.currentThread().getName().startsWith(metadataStoreNamePrefix), errorMessage);
};

// put with node which has parent(but the parent node is not exists).
Expand Down