Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][admin] Clusters list API return clusters with local flag #20593

Closed
wants to merge 3 commits into from

Conversation

Technoboy-
Copy link
Contributor

@Technoboy- Technoboy- commented Jun 16, 2023

Fixes #20581
PIP: #20614

Motivation

After configuring the geo-replication on Pulsar clusters, the clusters list API will return multiple clusters, including the local Pulsar cluster and remote clusters like

bin/pulsar-admin clusters list
us-west
us-east
us-cent

But in this return, you can't distinguish the local and the remote cluster. When you need to remove the geo-replication configuration, it will be hard to decide which cluster should be removed on replicated tenants and namespaces unless you record the cluster information.

Modification

Add local flag to distinguish clusters

bin/pulsar-admin clusters list
us-west(local)
us-east
us-cent

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@Technoboy- Technoboy- added this to the 3.1.0 milestone Jun 16, 2023
@Technoboy- Technoboy- self-assigned this Jun 16, 2023
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jun 16, 2023
@codelipenghui
Copy link
Contributor

@Technoboy- The change will introduce a new option to the existing CLI. It should start with a PIP for any public API changes.

@Technoboy- Technoboy- closed this Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improve][Admin API] Clusters list API return clusters with local and remote flag
2 participants