Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][doc] fix doc comment for subscriptionType #20987

Merged
merged 2 commits into from
Sep 17, 2023

Conversation

chenhongSZ
Copy link
Contributor

@chenhongSZ chenhongSZ commented Aug 14, 2023

Fixes #xyz

Main Issue: #xyz

PIP: #xyz

Motivation

add Key_Shared comment for subscriptionType

Modifications

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@github-actions
Copy link

@chenhongSZ Please add the following content to your PR description and select a checkbox:

- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->

@github-actions github-actions bot added doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. and removed doc-label-missing labels Aug 14, 2023
@chenhongSZ
Copy link
Contributor Author

/pulsarbot run-failure-checks

@codecov-commenter
Copy link

Codecov Report

Merging #20987 (a517e01) into master (550476f) will increase coverage by 36.36%.
Report is 6 commits behind head on master.
The diff coverage is 78.35%.

Impacted file tree graph

@@              Coverage Diff              @@
##             master   #20987       +/-   ##
=============================================
+ Coverage     36.84%   73.20%   +36.36%     
- Complexity    12179    32458    +20279     
=============================================
  Files          1698     1887      +189     
  Lines        130330   140048     +9718     
  Branches      14247    15427     +1180     
=============================================
+ Hits          48016   102527    +54511     
+ Misses        75966    29411    -46555     
- Partials       6348     8110     +1762     
Flag Coverage Δ
inttests 24.10% <10.30%> (-0.06%) ⬇️
systests 25.16% <8.24%> (+0.06%) ⬆️
unittests 72.47% <78.35%> (+40.50%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
.../pulsar/broker/stats/BrokerOperabilityMetrics.java 100.00% <ø> (ø)
...ache/pulsar/client/impl/MultiTopicsReaderImpl.java 78.49% <50.00%> (+30.14%) ⬆️
...java/org/apache/pulsar/client/impl/ReaderImpl.java 85.43% <50.00%> (+18.11%) ⬆️
...rg/apache/pulsar/client/impl/PulsarClientImpl.java 74.38% <66.66%> (+14.26%) ⬆️
...ar/broker/loadbalance/impl/UniformLoadShedder.java 81.48% <77.33%> (+81.48%) ⬆️
...tion/buffer/impl/TransactionBufferHandlerImpl.java 67.92% <100.00%> (+17.92%) ⬆️
...g/apache/pulsar/client/impl/ConnectionHandler.java 90.56% <100.00%> (+18.18%) ⬆️
.../org/apache/pulsar/client/impl/ConnectionPool.java 76.09% <100.00%> (+12.91%) ⬆️

... and 1440 files with indirect coverage changes

@Technoboy- Technoboy- added this to the 3.2.0 milestone Sep 17, 2023
@Technoboy- Technoboy- merged commit 62a88f9 into apache:master Sep 17, 2023
45 checks passed
@chenhongSZ chenhongSZ deleted the fixDocComment branch September 20, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Your PR contains doc changes, no matter whether the changes are in markdown or code files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants