Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][fn] Fix the --batch-builder not working error for functions #21023

Merged

Conversation

jiangpengcheng
Copy link
Contributor

Fixes #21022

Main Issue: #xyz

PIP: #xyz

Motivation

the --batch-builder argument not working for functions, the reason is that it just save it to the FunctionConfig, and the backend doesn't use the FunctionConfig.batchBuilder.

Modifications

check the FunctionConfig.batchBuilder in FunctionConfigUtils#convert method to set batch builder for the producer spec

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: jiangpengcheng#14

@Technoboy- Technoboy- closed this Sep 4, 2023
@Technoboy- Technoboy- reopened this Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] --batch-builder parameter doesn't work for function creating/updating
4 participants