-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][proxy] Support disabling metrics endpoint #21031
Merged
michaeljmarshall
merged 3 commits into
apache:master
from
michaeljmarshall:disable-proxy-stats
Aug 19, 2023
Merged
[improve][proxy] Support disabling metrics endpoint #21031
michaeljmarshall
merged 3 commits into
apache:master
from
michaeljmarshall:disable-proxy-stats
Aug 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaeljmarshall
added
area/proxy
doc-not-needed
Your PR changes do not impact docs
ready-to-test
labels
Aug 19, 2023
nicoloboschi
approved these changes
Aug 19, 2023
Codecov Report
@@ Coverage Diff @@
## master #21031 +/- ##
=============================================
+ Coverage 33.56% 73.11% +39.55%
- Complexity 12198 32174 +19976
=============================================
Files 1621 1875 +254
Lines 126970 139505 +12535
Branches 13857 15344 +1487
=============================================
+ Hits 42618 102001 +59383
+ Misses 78748 29436 -49312
- Partials 5604 8068 +2464
Flags with carried forward coverage won't be shown. Click here to find out more.
|
michaeljmarshall
added a commit
that referenced
this pull request
Aug 24, 2023
(cherry picked from commit d06cda6)
michaeljmarshall
added a commit
that referenced
this pull request
Aug 24, 2023
(cherry picked from commit d06cda6)
michaeljmarshall
added a commit
that referenced
this pull request
Aug 24, 2023
michaeljmarshall
added a commit
that referenced
this pull request
Aug 24, 2023
(cherry picked from commit d06cda6)
Closed
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In certain deployments, it is preferable to be able to disable the
/proxy-stats
,/metrics
, and/status.html
endpoints.Modifications
enableProxyStatsEndpoints
to the proxy configuration. When true (default), the endpoints are all exposed. When false, they are not served.Verifying this change
This is a minor change.
Documentation
doc-not-needed