-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][sec] Add group pulsar and add user pulsar to it instead of root #21084
Conversation
The pr had no activity for 30 days, mark with Stale label. |
Failed to build the image:
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #21084 +/- ##
=============================================
+ Coverage 36.79% 68.40% +31.61%
- Complexity 12223 32193 +19970
=============================================
Files 1698 1881 +183
Lines 130168 162542 +32374
Branches 14206 19987 +5781
=============================================
+ Hits 47890 111193 +63303
+ Misses 75951 42375 -33576
- Partials 6327 8974 +2647
Flags with carried forward coverage won't be shown. Click here to find out more. |
I think we need to revert and first do a PIP if we are doing this change. This change will break Openshift support. I'll provide more details as a follow-up. |
This PR #13376 provides more context and the reference about why root group must be used for OpenShift support:
|
Why did we merge this without addressing my questions on the mailing list? https://lists.apache.org/thread/34t3npt0368hppv1gk8wc808ofl786j3 I appreciate that you brought this to the mailing list @yaalsn, but we should not have merged this when there was active opposition and open questions. |
@michaeljmarshall Sorry, I should disscuss more. |
Motivation
Currently, the user pulsar is in the root group, it would be better to use the non-root group to keep more safety.
Modifications
Verifying this change
Documentation
doc
doc-required
doc-not-needed
doc-complete