Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor][broker] PIP-301 Part-1: Add BundleDataResources #21119

Merged
merged 10 commits into from
Oct 8, 2023

Conversation

AnonHxy
Copy link
Contributor

@AnonHxy AnonHxy commented Sep 4, 2023

Motivation

See pip: #21129

Modifications

Add BundleDataResources

Verifying this change

  • Make sure that the change passes the CI checks.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: AnonHxy#45

@AnonHxy AnonHxy closed this Sep 5, 2023
@AnonHxy AnonHxy reopened this Sep 5, 2023
@AnonHxy AnonHxy self-assigned this Sep 5, 2023
@AnonHxy AnonHxy changed the title [refactor][broker] Add BundleDataResources [refactor][broker] PIP-301 Part-1: Add BundleDataResources Sep 5, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #21119 (0fda81b) into master (5c9b72a) will increase coverage by 48.37%.
Report is 2 commits behind head on master.
The diff coverage is 81.69%.

Impacted file tree graph

@@              Coverage Diff              @@
##             master   #21119       +/-   ##
=============================================
+ Coverage     24.85%   73.23%   +48.37%     
- Complexity      197    32393    +32196     
=============================================
  Files          1696     1888      +192     
  Lines        130448   140170     +9722     
  Branches      14252    15428     +1176     
=============================================
+ Hits          32429   102653    +70224     
+ Misses        92949    29430    -63519     
- Partials       5070     8087     +3017     
Flag Coverage Δ
inttests 24.14% <65.51%> (?)
systests 24.77% <28.16%> (-0.09%) ⬇️
unittests 72.52% <81.69%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../pulsar/broker/resources/LoadBalanceResources.java 100.00% <100.00%> (ø)
...he/pulsar/broker/resources/NamespaceResources.java 80.14% <ø> (+41.41%) ⬆️
...pache/pulsar/broker/admin/impl/NamespacesBase.java 72.84% <100.00%> (+61.22%) ⬆️
...g/apache/pulsar/broker/admin/impl/TenantsBase.java 96.45% <100.00%> (+61.70%) ⬆️
...roker/loadbalance/impl/ModularLoadManagerImpl.java 81.60% <100.00%> (+24.46%) ⬆️
...rg/apache/pulsar/broker/web/PulsarWebResource.java 64.76% <100.00%> (+34.41%) ⬆️
...e/pulsar/io/elasticsearch/ElasticSearchClient.java 78.82% <100.00%> (+78.82%) ⬆️
...pache/pulsar/broker/resources/PulsarResources.java 84.78% <75.00%> (+1.06%) ⬆️
...che/pulsar/io/elasticsearch/ElasticSearchSink.java 75.75% <55.55%> (+75.75%) ⬆️

... and 1540 files with indirect coverage changes

@AnonHxy
Copy link
Contributor Author

AnonHxy commented Sep 26, 2023

@AnonHxy AnonHxy merged commit bbdc173 into apache:master Oct 8, 2023
45 checks passed
liangyuanpeng pushed a commit to liangyuanpeng/pulsar that referenced this pull request Oct 11, 2023
)

### Motivation

See pip: apache#21129

### Modifications

Add  `BundleDataResources`
vinayakmalik95 pushed a commit to tmdc-io/pulsar that referenced this pull request Oct 12, 2023
)

### Motivation

See pip: apache#21129

### Modifications

Add  `BundleDataResources`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-not-needed Your PR changes do not impact docs ready-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants