-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[refactor][broker] PIP-301 Part-1: Add BundleDataResources #21119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 4, 2023
AnonHxy
requested review from
Jason918,
michaeljmarshall,
merlimat,
mattisonchao,
heesung-sn,
HQebupt and
congbobo184
September 4, 2023 09:02
mattisonchao
reviewed
Sep 4, 2023
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/resources/BundleDataResources.java
Outdated
Show resolved
Hide resolved
AnonHxy
removed request for
merlimat,
Jason918,
HQebupt,
congbobo184,
michaeljmarshall and
heesung-sn
September 4, 2023 10:51
AnonHxy
changed the title
[refactor][broker] Add BundleDataResources
[refactor][broker] PIP-301 Part-1: Add BundleDataResources
Sep 5, 2023
AnonHxy
force-pushed
the
refactor_bundle_resources
branch
from
September 25, 2023 15:13
ea3595b
to
0fda81b
Compare
Codecov Report
@@ Coverage Diff @@
## master #21119 +/- ##
=============================================
+ Coverage 24.85% 73.23% +48.37%
- Complexity 197 32393 +32196
=============================================
Files 1696 1888 +192
Lines 130448 140170 +9722
Branches 14252 15428 +1176
=============================================
+ Hits 32429 102653 +70224
+ Misses 92949 29430 -63519
- Partials 5070 8087 +3017
Flags with carried forward coverage won't be shown. Click here to find out more.
|
AnonHxy
requested review from
merlimat,
HQebupt,
Technoboy-,
eolivelli,
codelipenghui and
congbobo184
September 26, 2023 02:16
congbobo184
approved these changes
Oct 7, 2023
liangyuanpeng
pushed a commit
to liangyuanpeng/pulsar
that referenced
this pull request
Oct 11, 2023
) ### Motivation See pip: apache#21129 ### Modifications Add `BundleDataResources`
vinayakmalik95
pushed a commit
to tmdc-io/pulsar
that referenced
this pull request
Oct 12, 2023
) ### Motivation See pip: apache#21129 ### Modifications Add `BundleDataResources`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
See pip: #21129
Modifications
Add
BundleDataResources
Verifying this change
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: AnonHxy#45