Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cleanup][misc] Delete .github/ISSUE_TEMPLATE/pip.md #21120

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

asafm
Copy link
Contributor

@asafm asafm commented Sep 4, 2023

Motivation

No need for that anymore. We have moved to submitting PIPs using PRs.

Modifications

Delete issue template named PIP.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

No need for that anymore
@asafm
Copy link
Contributor Author

asafm commented Sep 4, 2023

@codelipenghui @tisonkun Take a look

@asafm asafm changed the title [cleanup]misc] Delete .github/ISSUE_TEMPLATE/pip.md [cleanup][misc] Delete .github/ISSUE_TEMPLATE/pip.md Sep 4, 2023
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Sep 4, 2023
Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll merge in days if there is no objection.

@tisonkun tisonkun merged commit 209f222 into apache:master Sep 6, 2023
22 of 24 checks passed
@asafm asafm deleted the patch-1 branch September 18, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-not-needed Your PR changes do not impact docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants