Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve] [bookie] Enable forceAllowCompaction by default #21130

Conversation

hangc0276
Copy link
Contributor

Fixes #xyz

Main Issue: #xyz

PIP: #xyz

Motivation

When the ledger disk usage reaches 95%, the bookie will run into read-only mode. At the same time, the minor and major compaction will be disabled, which means there is no way to trigger the bookie garbage collection except by increasing the ledger disk size. It will be hard for the Pulsar Ops guys to maintain the BookKeeper cluster.

In order to support trigger major/minor compaction through REST API when the bookie disk usage reaches 95%, I pushed one PR on BookKeeper apache/bookkeeper#3205. However, it still needs to enable the forceAllowCompaction in the BookKeeper configuration.

Modifications

Enable the forceAllowCompaction by default in the BookKeeper configuration conf/bookkeeper.conf

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Sep 5, 2023
@hangc0276 hangc0276 self-assigned this Sep 5, 2023
@hangc0276 hangc0276 added this to the 3.2.0 milestone Sep 5, 2023
@Technoboy- Technoboy- merged commit 550476f into apache:master Sep 11, 2023
63 of 65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/config doc-not-needed Your PR changes do not impact docs ready-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants