Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve] [broker] Improve logs for troubleshooting #21141

Merged
merged 2 commits into from
Sep 6, 2023

Conversation

poorbarcode
Copy link
Contributor

Motivation

  • The log of NonDurableCursorImpl does not print the cursor name
  • When catching exception ConsumerBusyException, no specific details were printed

Modifications

Improve logs for troubleshooting

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: x

@poorbarcode poorbarcode self-assigned this Sep 6, 2023
@poorbarcode poorbarcode added this to the 3.2.0 milestone Sep 6, 2023
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Sep 6, 2023
@poorbarcode poorbarcode added release/3.0.2 release/2.11.3 release/2.10.6 and removed doc-not-needed Your PR changes do not impact docs labels Sep 6, 2023
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Sep 6, 2023
@poorbarcode
Copy link
Contributor Author

/pulsarbot rerun-failure-checks

@codecov-commenter
Copy link

Codecov Report

Merging #21141 (e960168) into master (88231f7) will increase coverage by 0.01%.
The diff coverage is 76.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #21141      +/-   ##
============================================
+ Coverage     73.21%   73.22%   +0.01%     
- Complexity    32452    32455       +3     
============================================
  Files          1887     1887              
  Lines        140004   140013       +9     
  Branches      15423    15423              
============================================
+ Hits         102502   102523      +21     
+ Misses        29410    29400      -10     
+ Partials       8092     8090       -2     
Flag Coverage Δ
inttests 24.11% <56.00%> (-0.08%) ⬇️
systests 25.09% <48.00%> (+0.09%) ⬆️
unittests 72.51% <76.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...sar/broker/service/persistent/PersistentTopic.java 80.39% <50.00%> (-0.15%) ⬇️
...che/bookkeeper/mledger/impl/ManagedCursorImpl.java 79.17% <73.33%> (-0.13%) ⬇️
.../bookkeeper/mledger/impl/NonDurableCursorImpl.java 85.41% <100.00%> (+1.32%) ⬆️

... and 66 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants