[improve] [broker] Let the producer request success at the first time if the previous one is inactive #21220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poorbarcode
requested review from
Technoboy-,
codelipenghui and
liangyepianzhou
4 tasks
poorbarcode
added
release/3.0.2
release/2.11.3
release/2.10.6
category/reliability
|
The pr had no activity for 30 days, mark with Stale label. |
… if the previous is inactive
poorbarcode
force-pushed
the
improve/producer_success_at_first_time
branch
from
3709b39
to
8710eb5
Compare
codelipenghui
approved these changes
Nov 1, 2023
| "Producer with name '" + newProducer.getProducerName() | ||
| + "' is already connected to topic")); | ||
| } else { | ||
| return internalAddProducer(newProducer); |
There was a problem hiding this comment.
It's better to add a comment here to explain why we should take a recursive call.
There was a problem hiding this comment.
And it also should be BUG before, right?
There was a problem hiding this comment.
It's better to add a comment here to explain why we should take a recursive call.
Done
And it also should be BUG before, right?
Yes, the issue is that the producer creation will fail if a same-name producer has already closed on the client side.
liangyepianzhou
approved these changes
Nov 2, 2023
Codecov Report
@@ Coverage Diff @@
## master #21220 +/- ##
=============================================
+ Coverage 36.74% 73.23% +36.48%
- Complexity 375 32607 +32232
=============================================
Files 1713 1890 +177
Lines 130808 140428 +9620
Branches 14256 15434 +1178
=============================================
+ Hits 48068 102841 +54773
+ Misses 76375 29498 -46877
- Partials 6365 8089 +1724
Flags with carried forward coverage won't be shown. Click here to find out more.
|
nborisov
pushed a commit
to nborisov/pulsar
that referenced
this pull request
Nov 13, 2023
… if the previous one is inactive (apache#21220) ### Motivation If a producer establishes a new connection when it is reconnecting, while the previous connection is now inactive, the initial request made on the new connection will fail. This failure will trigger the topic of cleaning up the inactive producers. However, upon making a second request, the producer will be able to successfully establish a connection and proceed with the operation. ### Modifications Make the initial request made on the new connection success.
Technoboy-
pushed a commit
that referenced
this pull request
Nov 23, 2023
… if the previous one is inactive (#21220) ### Motivation If a producer establishes a new connection when it is reconnecting, while the previous connection is now inactive, the initial request made on the new connection will fail. This failure will trigger the topic of cleaning up the inactive producers. However, upon making a second request, the producer will be able to successfully establish a connection and proceed with the operation. ### Modifications Make the initial request made on the new connection success.
|
There are conflicts when cherry pick this patch to branch-3.1, would you please help do it @poorbarcode |
poorbarcode
added a commit
that referenced
this pull request
Nov 28, 2023
… if the previous one is inactive (#21220) If a producer establishes a new connection when it is reconnecting, while the previous connection is now inactive, the initial request made on the new connection will fail. This failure will trigger the topic of cleaning up the inactive producers. However, upon making a second request, the producer will be able to successfully establish a connection and proceed with the operation. Make the initial request made on the new connection success. (cherry picked from commit 711b621)
Done |
poorbarcode
added a commit
that referenced
this pull request
Nov 28, 2023
… if the previous one is inactive (#21220) If a producer establishes a new connection when it is reconnecting, while the previous connection is now inactive, the initial request made on the new connection will fail. This failure will trigger the topic of cleaning up the inactive producers. However, upon making a second request, the producer will be able to successfully establish a connection and proceed with the operation. Make the initial request made on the new connection success. (cherry picked from commit 40f94d5)
poorbarcode
added a commit
that referenced
this pull request
Nov 28, 2023
… if the previous one is inactive (#21220) If a producer establishes a new connection when it is reconnecting, while the previous connection is now inactive, the initial request made on the new connection will fail. This failure will trigger the topic of cleaning up the inactive producers. However, upon making a second request, the producer will be able to successfully establish a connection and proceed with the operation. Make the initial request made on the new connection success. (cherry picked from commit 40f94d5)
poorbarcode
added a commit
that referenced
this pull request
Nov 28, 2023
… if the previous one is inactive (#21220) ### Motivation If a producer establishes a new connection when it is reconnecting, while the previous connection is now inactive, the initial request made on the new connection will fail. This failure will trigger the topic of cleaning up the inactive producers. However, upon making a second request, the producer will be able to successfully establish a connection and proceed with the operation. ### Modifications Make the initial request made on the new connection success. (cherry picked from commit 40f94d5)
nodece
pushed a commit
to ascentstream/pulsar
that referenced
this pull request
Dec 2, 2023
… if the previous one is inactive (apache#21220) If a producer establishes a new connection when it is reconnecting, while the previous connection is now inactive, the initial request made on the new connection will fail. This failure will trigger the topic of cleaning up the inactive producers. However, upon making a second request, the producer will be able to successfully establish a connection and proceed with the operation. Make the initial request made on the new connection success. (cherry picked from commit 40f94d5)
nodece
pushed a commit
to ascentstream/pulsar
that referenced
this pull request
Dec 2, 2023
…rst time if the previous one is inactive (apache#21220)" This reverts commit 918e746.
nodece
pushed a commit
to ascentstream/pulsar
that referenced
this pull request
Dec 2, 2023
… if the previous one is inactive (apache#21220) If a producer establishes a new connection when it is reconnecting, while the previous connection is now inactive, the initial request made on the new connection will fail. This failure will trigger the topic of cleaning up the inactive producers. However, upon making a second request, the producer will be able to successfully establish a connection and proceed with the operation. Make the initial request made on the new connection success. (cherry picked from commit 40f94d5)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Dec 20, 2023
… if the previous one is inactive (apache#21220) If a producer establishes a new connection when it is reconnecting, while the previous connection is now inactive, the initial request made on the new connection will fail. This failure will trigger the topic of cleaning up the inactive producers. However, upon making a second request, the producer will be able to successfully establish a connection and proceed with the operation. Make the initial request made on the new connection success. (cherry picked from commit 711b621)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Dec 20, 2023
… if the previous one is inactive (apache#21220) If a producer establishes a new connection when it is reconnecting, while the previous connection is now inactive, the initial request made on the new connection will fail. This failure will trigger the topic of cleaning up the inactive producers. However, upon making a second request, the producer will be able to successfully establish a connection and proceed with the operation. Make the initial request made on the new connection success. (cherry picked from commit 711b621)
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
See #21155 (comment)
If a producer establishes a new connection when it is reconnecting, while the previous connection is now inactive, the initial request made on the new connection will fail. This failure will trigger the topic of cleaning up the inactive producers. However, upon making a second request, the producer will be able to successfully establish a connection and proceed with the operation.
Modifications
Make the initial request made on the new connection success.
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: x