Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][proxy] Move status endpoint out of auth coverage #21428

Merged
merged 2 commits into from
Oct 24, 2023
Merged

[fix][proxy] Move status endpoint out of auth coverage #21428

merged 2 commits into from
Oct 24, 2023

Conversation

mattisonchao
Copy link
Member

Motivation

Some vendors don’t support health checks with authentication like AWS health checks. Which will make it hard to integrate with the vendor.

Modifications

  • Move the status.html endpoint out of auth coverage.

Verifying this change

  • Make sure that the change passes the CI checks.
  • Added pulsar-proxy/src/test/java/org/apache/pulsar/proxy/server/ProxyWithJwtAuthorizationTest.java testGetStatus to avoid regression.

Does this pull request potentially affect one of the following parts:

  • The REST endpoints

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

The tests will be run in the forked repository until all PR review comments have
been handled, the tests pass and the PR is approved by a reviewer.
-->

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Oct 24, 2023
@mattisonchao mattisonchao self-assigned this Oct 24, 2023
@mattisonchao mattisonchao added this to the 3.2.0 milestone Oct 24, 2023
@mattisonchao mattisonchao reopened this Oct 24, 2023
@mattisonchao mattisonchao added area/proxy category/reliability The function does not work properly in certain specific environments or failures. e.g. data lost labels Oct 24, 2023
@mattisonchao mattisonchao changed the title [fix][proxy] Move status check out of auth coverage [fix][proxy] Move status endpoint out of auth coverage Oct 24, 2023
@mattisonchao mattisonchao merged commit fe2d61d into apache:master Oct 24, 2023
68 of 74 checks passed
@mattisonchao mattisonchao deleted the improve/move_status_out_of_authentication branch October 24, 2023 11:08
shibd pushed a commit that referenced this pull request Oct 25, 2023
@compuguy
Copy link

compuguy commented Oct 25, 2023

Is there any way for this merge request to be put into a 3.1.x release? Not having the status.html behind authentication breaks most Kubernetes helm charts that use /status.html for liveness and readiness checks for the proxy pods if one uses the just released 3.1.1 containers....

lhotari pushed a commit that referenced this pull request Oct 25, 2023
@mattisonchao
Copy link
Member Author

@compuguy We will cherry-pick it to all the active branches. :)

lhotari pushed a commit that referenced this pull request Oct 25, 2023
@lhotari
Copy link
Member

lhotari commented Oct 25, 2023

@compuguy We will cherry-pick it to all the active branches. :)

it's done now. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants