Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][test] Fix multiple thread leaks in tests, part 2 #21513

Merged

Conversation

lhotari
Copy link
Member

@lhotari lhotari commented Nov 3, 2023

Motivation

There are thread leaks in tests reported by the thread leak detection added in #21450.

Modifications

Fix multiple thread leaks in unit tests.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@lhotari lhotari added this to the 3.2.0 milestone Nov 3, 2023
@lhotari lhotari self-assigned this Nov 3, 2023
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Nov 3, 2023
@lhotari lhotari force-pushed the lh-fix-even-more-thread-leaks-in-tests-2 branch from 5d0ae54 to a832e89 Compare November 3, 2023 22:38
@codecov-commenter
Copy link

Codecov Report

Merging #21513 (a832e89) into master (99e6aeb) will decrease coverage by 0.03%.
Report is 1 commits behind head on master.
The diff coverage is 90.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #21513      +/-   ##
============================================
- Coverage     73.22%   73.20%   -0.03%     
+ Complexity    32607    32604       -3     
============================================
  Files          1890     1890              
  Lines        140444   140451       +7     
  Branches      15436    15436              
============================================
- Hits         102839   102812      -27     
- Misses        29504    29542      +38     
+ Partials       8101     8097       -4     
Flag Coverage Δ
inttests 24.12% <20.00%> (-0.09%) ⬇️
systests 24.71% <20.00%> (+0.01%) ⬆️
unittests 72.51% <90.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...a/org/apache/pulsar/proxy/server/ProxyService.java 78.84% <90.00%> (+0.19%) ⬆️

... and 78 files with indirect coverage changes

@lhotari lhotari merged commit a8d09ce into apache:master Nov 4, 2023
48 checks passed
nborisov pushed a commit to nborisov/pulsar that referenced this pull request Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants