-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][sec] Add a check for the input time value #22023
Conversation
pulsar-broker/src/main/java/org/apache/pulsar/broker/stats/DimensionStats.java
Outdated
Show resolved
Hide resolved
...broker/src/main/java/org/apache/pulsar/broker/stats/prometheus/metrics/LongAdderCounter.java
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #22023 +/- ##
============================================
- Coverage 73.57% 73.55% -0.02%
- Complexity 32575 32627 +52
============================================
Files 1874 1877 +3
Lines 139252 139527 +275
Branches 15260 15306 +46
============================================
+ Hits 102454 102632 +178
- Misses 28880 28933 +53
- Partials 7918 7962 +44
Flags with carried forward coverage won't be shown. Click here to find out more.
|
plz add release labels |
(cherry picked from commit 31ed115)
(cherry picked from commit 60fed0d)
(cherry picked from commit 60fed0d)
This breaks Flink SQL Connector due to the usage of -1 as the default in https://github.com/apache/flink-connector-pulsar/blob/5889eb21d13126f0b4e616cabb6f07365188215e/flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/common/config/PulsarOptions.java#L136. I added #22242 to track this regression. |
This reverts commit 90416ab.
This reverts commit 31ed115.
This reverts commit 31ed115.
…pache#22023)" (apache#22243) (cherry picked from commit ffff639) (cherry picked from commit c0fd8d3)
…pache#22023)" (apache#22243) (cherry picked from commit ffff639) (cherry picked from commit c0fd8d3)
Motivation
The time value should not be a negative value. We need to add a check when get a time value input.
Modifications
Add a check when get a time value input.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: