-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][broker] Add an error log to troubleshoot the failure of starting broker registry. #22065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rting broker registry.
poorbarcode
approved these changes
Feb 18, 2024
...src/main/java/org/apache/pulsar/broker/loadbalance/extensions/ExtensibleLoadManagerImpl.java
Outdated
Show resolved
Hide resolved
congbobo184
approved these changes
Feb 18, 2024
Demogorgon314
approved these changes
Feb 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
nodece
approved these changes
Feb 18, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #22065 +/- ##
============================================
+ Coverage 73.48% 73.57% +0.09%
- Complexity 32465 32553 +88
============================================
Files 1863 1874 +11
Lines 138812 139221 +409
Branches 15215 15260 +45
============================================
+ Hits 102003 102433 +430
+ Misses 28921 28869 -52
- Partials 7888 7919 +31
Flags with carried forward coverage won't be shown. Click here to find out more.
|
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Mar 1, 2024
…rting broker registry. (apache#22065) (cherry picked from commit baddda5) (cherry picked from commit 71022f5)
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Mar 6, 2024
…rting broker registry. (apache#22065) (cherry picked from commit baddda5) (cherry picked from commit 71022f5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cherry-picked/branch-3.0
cherry-picked/branch-3.1
cherry-picked/branch-3.2
doc-not-needed
Your PR changes do not impact docs
release/3.0.3
release/3.1.3
release/3.2.1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When the
ExtensibleLoadManagerImpl.java
fails to start, it will closebrokerRegistry
. But we cannot directly determine why the broker register is closed.Modifications
Add an error log when the
ExtensibleLoadManagerImpl.java
fails to start,Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: