-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] Upgrade jose4j to 0.9.4 #22273
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #22273 +/- ##
============================================
+ Coverage 73.57% 73.62% +0.04%
- Complexity 32624 32722 +98
============================================
Files 1877 1887 +10
Lines 139502 139391 -111
Branches 15299 15287 -12
============================================
- Hits 102638 102620 -18
+ Misses 28908 28828 -80
+ Partials 7956 7943 -13
Flags with carried forward coverage won't be shown. Click here to find out more. |
lhotari
approved these changes
Mar 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
lhotari
pushed a commit
that referenced
this pull request
Mar 15, 2024
(cherry picked from commit 999e39b)
lhotari
pushed a commit
that referenced
this pull request
Mar 15, 2024
(cherry picked from commit 999e39b) # Conflicts: # distribution/server/src/assemble/LICENSE.bin.txt
lhotari
pushed a commit
that referenced
this pull request
Mar 15, 2024
(cherry picked from commit 999e39b)
lhotari
pushed a commit
that referenced
this pull request
Mar 15, 2024
(cherry picked from commit 999e39b)
lhotari
pushed a commit
that referenced
this pull request
Mar 15, 2024
(cherry picked from commit 999e39b)
nodece
pushed a commit
to ascentstream/pulsar
that referenced
this pull request
May 13, 2024
(cherry picked from commit 999e39b) # Conflicts: # distribution/server/src/assemble/LICENSE.bin.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Pin Jose4j library lib to latest version. This is a dependency of K8S Java client API.
org.bitbucket.b_c:jose4j:jar:0.9.4:compile
which has a fix for:Modifications
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: