Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Upgrade jose4j to 0.9.4 #22273

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Conversation

merlimat
Copy link
Contributor

Motivation

Pin Jose4j library lib to latest version. This is a dependency of K8S Java client API.
org.bitbucket.b_c:jose4j:jar:0.9.4:compile which has a fix for:

┌──────────────────────────────────────┬────────────────┬──────────┬────────┬───────────────────┬───────────────┬─────────────────────────────────────────────────────────────┐
│               Library                │ Vulnerability  │ Severity │ Status │ Installed Version │ Fixed Version │                            Title                            │
├──────────────────────────────────────┼────────────────┼──────────┼────────┼───────────────────┼───────────────┼─────────────────────────────────────────────────────────────┤
│ org.bitbucket.b_c:jose4j             │ CVE-2023-51775 │ MEDIUM   │ fixed  │ 0.9.3             │ 0.9.4         │ jose4j: denial of service (CPU consumption) via a large p2c │
│ (org.bitbucket.b_c-jose4j-0.9.3.jar) │                │          │        │                   │               │ (aka PBES2...                                               │
│                                      │                │          │        │                   │               │ https://avd.aquasec.com/nvd/cve-2023-51775                  │
└──────────────────────────────────────┴────────────────┴──────────┴────────┴───────────────────┴───────────────┴─────────────────────────────────────────────────────────────┘

Modifications

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@merlimat merlimat added this to the 3.3.0 milestone Mar 15, 2024
@merlimat merlimat requested a review from Technoboy- March 15, 2024 01:13
@merlimat merlimat self-assigned this Mar 15, 2024
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Mar 15, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.62%. Comparing base (bbc6224) to head (8ee7983).
Report is 54 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #22273      +/-   ##
============================================
+ Coverage     73.57%   73.62%   +0.04%     
- Complexity    32624    32722      +98     
============================================
  Files          1877     1887      +10     
  Lines        139502   139391     -111     
  Branches      15299    15287      -12     
============================================
- Hits         102638   102620      -18     
+ Misses        28908    28828      -80     
+ Partials       7956     7943      -13     
Flag Coverage Δ
inttests 26.97% <ø> (+2.39%) ⬆️
systests 24.40% <ø> (+0.08%) ⬆️
unittests 72.88% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 104 files with indirect coverage changes

Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhotari lhotari merged commit 999e39b into apache:master Mar 15, 2024
55 of 56 checks passed
lhotari pushed a commit that referenced this pull request Mar 15, 2024
lhotari pushed a commit that referenced this pull request Mar 15, 2024
(cherry picked from commit 999e39b)

# Conflicts:
#	distribution/server/src/assemble/LICENSE.bin.txt
lhotari pushed a commit that referenced this pull request Mar 15, 2024
lhotari pushed a commit that referenced this pull request Mar 15, 2024
lhotari pushed a commit that referenced this pull request Mar 15, 2024
nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request Apr 3, 2024
(cherry picked from commit 999e39b)
(cherry picked from commit be3be09)
nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request Apr 4, 2024
(cherry picked from commit 999e39b)
(cherry picked from commit be3be09)
nodece pushed a commit to ascentstream/pulsar that referenced this pull request May 13, 2024
(cherry picked from commit 999e39b)

# Conflicts:
#	distribution/server/src/assemble/LICENSE.bin.txt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants