Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Partitioned topics fix #226

Merged
merged 3 commits into from
Feb 18, 2017
Merged

Partitioned topics fix #226

merged 3 commits into from
Feb 18, 2017

Conversation

jai1
Copy link
Contributor

@jai1 jai1 commented Feb 18, 2017

Motivation

Details explained in Issue #212

Modifications

  • Modified the test cases to fail if the Partitioned topics are not created
  • Added media type in curl header
  • Corrected url sent to create partitions

Result

Partitioned topics test cases run successfully

rdhabalia
rdhabalia approved these changes Feb 18, 2017
View reviewed changes
Copy link
Contributor

@rdhabalia rdhabalia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rdhabalia rdhabalia added the type/bug The PR fixed a bug or issue reported a bug label Feb 18, 2017
@rdhabalia rdhabalia added this to the 1.17 milestone Feb 18, 2017
merlimat
merlimat approved these changes Feb 18, 2017
View reviewed changes
Copy link
Contributor

@merlimat merlimat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@merlimat merlimat added c++ area/test and removed type/bug The PR fixed a bug or issue reported a bug labels Feb 18, 2017
@merlimat merlimat merged commit d62cf07 into apache:master Feb 18, 2017
@jai1 jai1 deleted the PartitionedTopicsFix branch March 6, 2017 17:43
sijie pushed a commit to sijie/pulsar that referenced this pull request Mar 4, 2018
@jerrypeng @sijie
adding instance id to get status (apache#226)
0393713 
* adding instance id to get status

* regen python protobuf

* cleaning up
hrsakai pushed a commit to hrsakai/pulsar that referenced this pull request Dec 10, 2020
@cckellogg
Add flag to disable forced topic creation. (apache#226)
6edc8f4 
This flag is needed for the regex consumer.
@xiaotongwang1 xiaotongwang1 mentioned this pull request Aug 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdhabalia rdhabalia rdhabalia approved these changes

@merlimat merlimat merlimat approved these changes

Assignees

@jai1 jai1

Labels
area/test
Projects
None yet
Milestone
1.17
Development

Successfully merging this pull request may close these issues.
3 participants
@jai1 @merlimat @rdhabalia