[fix][client] Fix ReaderBuilder doest not give illegalArgument on connection failure retry #22639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdhabalia
added
area/client
doc-not-needed
…nection failure retry
dao-jun
requested changes
May 2, 2024
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ReaderBuilderImpl.java
Outdated
Show resolved
Hide resolved
dao-jun
approved these changes
May 8, 2024
|
the check that needed to be revisited was added in #6392 |
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 15, 2024
…nection failure retry (apache#22639) (cherry picked from commit b56f238) (cherry picked from commit 8b2d5e9)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 16, 2024
…nection failure retry (apache#22639) (cherry picked from commit b56f238) (cherry picked from commit 8b2d5e9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22638
Motivation
Currently when Reader Builder is used to create Reader with
startMessageFromRollbackDurationand if it fails due to connection issue and application retries to create a new Reader again then it throws IllegalArgument Exception even though Reader doesn't have any incorrect argument and that confuses the users.Modifications
Application should be able to retry and able to recreate Reader using the ReaderBuilder if it fails due to connection issue.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: