-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] [broker] Internal reader of __change_events can not started after metadata store session rebuilt #23018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #23018 +/- ##
============================================
- Coverage 73.57% 73.45% -0.13%
- Complexity 32624 33216 +592
============================================
Files 1877 1917 +40
Lines 139502 144072 +4570
Branches 15299 15743 +444
============================================
+ Hits 102638 105824 +3186
- Misses 28908 30131 +1223
- Partials 7956 8117 +161
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Can we cover the new load balancer behavior too? |
Sure, I will push two following PRs to do this:
|
poorbarcode
changed the title
[improve] [test] Add a test: topic will be unloaded after metadata store session rebuilt
[fix] [broker] Topic should be unloaded after metadata store session expired
Jul 10, 2024
poorbarcode
changed the title
[fix] [broker] Topic should be unloaded after metadata store session expired
[fix] [broker] Internal reader of __change_events can not started after metadata store session rebuilt
Jul 10, 2024
merlimat
reviewed
Jul 10, 2024
pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/AbstractMetadataStore.java
Show resolved
Hide resolved
shibd
approved these changes
Jul 23, 2024
poorbarcode
force-pushed
the
test/zk_session_expire
branch
from
July 26, 2024 00:33
68143c4
to
bf8b6a9
Compare
Technoboy-
reviewed
Jul 29, 2024
pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/AbstractMetadataStore.java
Outdated
Show resolved
Hide resolved
Technoboy-
approved these changes
Jul 29, 2024
lhotari
reviewed
Jul 29, 2024
pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/AbstractMetadataStore.java
Outdated
Show resolved
Hide resolved
lhotari
approved these changes
Jul 29, 2024
lhotari
added
release/3.2.4
release/3.2.5
release/3.0.7
and removed
release/3.2.4
release/3.0.6
labels
Jul 29, 2024
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 30, 2024
…er metadata store session rebuilt (apache#23018) (cherry picked from commit b955c65) (cherry picked from commit 0e59678)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 30, 2024
…er metadata store session rebuilt (apache#23018) (cherry picked from commit b955c65) (cherry picked from commit 0e59678)
Open
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cherry-picked/branch-3.0
cherry-picked/branch-3.2
cherry-picked/branch-3.3
doc-not-needed
Your PR changes do not impact docs
ready-to-test
release/3.0.7
release/3.2.5
release/3.3.2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation & Modifications
1. Fix the issue below
systemTopic & topicLevelPolicies
.broker-2
loads atopic-a
up.broker-2
loads system topic({ns}/__change_events
) up.topic-a
was transferred tobroker-0
{ns}/__change_events
) was transferred tobroker-0
broker-2
{ns}/__change_events
lookup the topic's ownerbroker-2
respondsbroker-2
due to itsOwnershipCache
contains the old value.{ns}/__change_events
can not be created successfully, all topics under this namespace can not work.broker-2
will get a wrong value, and keep getting a "Please redo the lookup" error.2. Add a test to confirm the topic will be unloaded after the metadata store session is rebuilt.
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: x