[fix][broker] Fix stuck when enable topic level replication and build remote admin fails #23028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanmz
approved these changes
Jul 14, 2024
Technoboy-
approved these changes
Jul 14, 2024
Technoboy-
changed the title
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 15, 2024
… remote admin fails (apache#23028) (cherry picked from commit 88ebe78) (cherry picked from commit 16da5f7)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 15, 2024
… remote admin fails (apache#23028) (cherry picked from commit 88ebe78) (cherry picked from commit 16da5f7)
nodece
pushed a commit
to nodece/pulsar
that referenced
this pull request
Sep 10, 2024
… remote admin fails (apache#23028) (cherry picked from commit 88ebe78) Signed-off-by: Zixuan Liu <nodeces@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The method
BrokerService. getClusterPulsarAdminwill throw exceptions and the methodtopics set replicated clustersdid not catch the exception, which leads to the complete future can not be completed. Eventually, the APIenbale topic-level replicationgets stuck.Modifications
fix the bug
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: x