-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][build] Move docker-push profile to submodule #23093
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
4 tasks
lhotari
approved these changes
Jul 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #23093 +/- ##
============================================
- Coverage 73.57% 73.44% -0.14%
- Complexity 32624 33524 +900
============================================
Files 1877 1919 +42
Lines 139502 144087 +4585
Branches 15299 15745 +446
============================================
+ Hits 102638 105824 +3186
- Misses 28908 30145 +1237
- Partials 7956 8118 +162
Flags with carried forward coverage won't be shown. Click here to find out more. |
nodece
added a commit
to ascentstream/pulsar
that referenced
this pull request
Aug 28, 2024
Signed-off-by: Zixuan Liu <nodeces@gmail.com> (cherry picked from commit 47d35a0)
nodece
added a commit
to ascentstream/pulsar
that referenced
this pull request
Oct 17, 2024
Signed-off-by: Zixuan Liu <nodeces@gmail.com> (cherry picked from commit 47d35a0)
nodece
added a commit
to nodece/pulsar
that referenced
this pull request
Oct 24, 2024
Signed-off-by: Zixuan Liu <nodeces@gmail.com> (cherry picked from commit 47d35a0)
nodece
added a commit
that referenced
this pull request
Oct 29, 2024
Signed-off-by: Zixuan Liu <nodeces@gmail.com> (cherry picked from commit 47d35a0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The profile refactoring breaks the pulsar release in the #23091.
Modifications
Documentation
doc
doc-required
doc-not-needed
doc-complete