Fix reset on closed cursors #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sschepens
force-pushed
the
reset_closed_cursor
branch
2 times, most recently
from
e6d51f5 to
2c3bfbe
Compare
sschepens
force-pushed
the
reset_closed_cursor
branch
from
2c3bfbe to
7c69b48
Compare
|
@merlimat can you have a look a this? |
|
@sschepens I didn't forget about these PRs. I'll get to them today. |
merlimat
approved these changes
Feb 28, 2017
|
great, now build is failing because S3 is down 😆 |
sijie
added a commit
to sijie/pulsar
that referenced
this pull request
Mar 4, 2018
…r electing a leader (apache#231)
hangc0276
pushed a commit
to hangc0276/pulsar
that referenced
this pull request
May 26, 2021
kop data flow works like this: kafka client(1) -> kop/broker (2)-> bookkeeper Right now we can use throttler to slow down (2) data flood, but (1) doesn't have any protection. This pr is used to enable/disable auto read for (1) channel. With this, we can controll the speed of channel in case of potential oom issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to fix #230
Would this be enough @merlimat ?
In case
cursorLedgerisnullI update metastore info instead of creating a new ledger.