[fix][build] Remove unnecessary Oracle maven repository from pom.xml #23132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhotari
added
type/bug
lhotari
requested review from
Technoboy-,
eolivelli,
codelipenghui,
nodece,
nicoloboschi and
poorbarcode
4 tasks
Technoboy-
approved these changes
Aug 7, 2024
BewareMyPower
approved these changes
Aug 7, 2024
|
Looks like it was required for this purpose: It seems odd that there would be a need to add an Oracle repository for rabbitmq client. |
|
Pulled in to test dependencies in pulsar-io/rabbitmq |
lhotari
changed the title
Denovo1998
pushed a commit
to Denovo1998/pulsar
that referenced
this pull request
Aug 17, 2024
grssam
pushed a commit
to grssam/pulsar
that referenced
this pull request
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The build stalled because the Oracle maven repository in pom.xml. There seemed to be an temporary availability issue with the repository. The repository was added in PR #22391 to test scope since qpid requires com.sleepycat:je dependency. It's better to get rid of this repository.
Modifications
Remove the Oracle maven repository from pom.xml and configure the test Qpid broker to use memory only mode so that the com.sleepycat:je dependency isn't required.
Documentation
docdoc-requireddoc-not-neededdoc-complete