Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][broker] PIP-376: Make topic policies service pluggable #23319

Conversation

BewareMyPower
Copy link
Contributor

@BewareMyPower BewareMyPower commented Sep 19, 2024

PIP: #23248

Modifications

Adapting to the new interface according to the PIP documents.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: BewareMyPower#35

@BewareMyPower BewareMyPower self-assigned this Sep 19, 2024
@BewareMyPower BewareMyPower added this to the 4.0.0 milestone Sep 19, 2024
@github-actions github-actions bot added the doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. label Sep 19, 2024
Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good work @BewareMyPower!

@BewareMyPower
Copy link
Contributor Author

The latest commit might cause some infinite loops. Let me investigate the failed tests.

@BewareMyPower BewareMyPower marked this pull request as draft September 19, 2024 10:12
@BewareMyPower BewareMyPower marked this pull request as ready for review September 19, 2024 10:42
@BewareMyPower BewareMyPower merged commit 4b3b273 into apache:master Sep 19, 2024
50 of 51 checks passed
@BewareMyPower BewareMyPower deleted the bewaremypower/pluggable-topic-policies-service branch September 21, 2024 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. PIP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants