Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][cli] Fix Pulsar-Client CLI to print metadata of message including encryption metadata #23347

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

rdhabalia
Copy link
Contributor

Motivation

Currently, client-cli doesn't print encryption related metadata which requires in my cases by users to troubleshoot encryption/decryption related issues and validate key related metadata.

Modifications

Add --print-metadata param in client-cli for consumer to allow to print additional metadata of the message.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@rdhabalia rdhabalia added area/cli doc-not-needed Your PR changes do not impact docs ready-to-test labels Sep 24, 2024
@rdhabalia rdhabalia self-assigned this Sep 24, 2024
Copy link

@rdhabalia Please add the following content to your PR description and select a checkbox:

- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->

@github-actions github-actions bot removed the doc-not-needed Your PR changes do not impact docs label Sep 24, 2024
Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rdhabalia rdhabalia force-pushed the enc_param1 branch 2 times, most recently from 8a1ff25 to 52c4217 Compare September 25, 2024 19:07
@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 11.11111% with 32 lines in your changes missing coverage. Please review.

Project coverage is 74.51%. Comparing base (bbc6224) to head (c5f40df).
Report is 602 commits behind head on master.

Files with missing lines Patch % Lines
...g/apache/pulsar/client/cli/AbstractCmdConsume.java 0.00% 31 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #23347      +/-   ##
============================================
+ Coverage     73.57%   74.51%   +0.93%     
- Complexity    32624    34421    +1797     
============================================
  Files          1877     1934      +57     
  Lines        139502   145028    +5526     
  Branches      15299    15846     +547     
============================================
+ Hits         102638   108063    +5425     
+ Misses        28908    28697     -211     
- Partials       7956     8268     +312     
Flag Coverage Δ
inttests 27.84% <5.55%> (+3.26%) ⬆️
systests 24.57% <0.00%> (+0.24%) ⬆️
unittests 73.85% <11.11%> (+1.00%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../java/org/apache/pulsar/client/cli/CmdConsume.java 42.33% <100.00%> (+1.03%) ⬆️
...ain/java/org/apache/pulsar/client/cli/CmdRead.java 42.14% <100.00%> (+1.00%) ⬆️
...g/apache/pulsar/client/cli/AbstractCmdConsume.java 16.39% <0.00%> (-4.07%) ⬇️

... and 594 files with indirect coverage changes

@rdhabalia rdhabalia merged commit b1c5d96 into apache:master Sep 25, 2024
51 checks passed
@rdhabalia rdhabalia deleted the enc_param1 branch September 25, 2024 22:31
@lhotari lhotari added this to the 4.0.0 milestone Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants