-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][cli] Fix Pulsar-Client CLI to print metadata of message including encryption metadata #23347
Conversation
@rdhabalia Please add the following content to your PR description and select a checkbox:
|
pulsar-client-tools/src/main/java/org/apache/pulsar/client/cli/CmdRead.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
8a1ff25
to
52c4217
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #23347 +/- ##
============================================
+ Coverage 73.57% 74.51% +0.93%
- Complexity 32624 34421 +1797
============================================
Files 1877 1934 +57
Lines 139502 145028 +5526
Branches 15299 15846 +547
============================================
+ Hits 102638 108063 +5425
+ Misses 28908 28697 -211
- Partials 7956 8268 +312
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…ng encryption metadata Fix checkstyle
52c4217
to
c5f40df
Compare
Motivation
Currently, client-cli doesn't print encryption related metadata which requires in my cases by users to troubleshoot encryption/decryption related issues and validate key related metadata.
Modifications
Add
--print-metadata
param in client-cli for consumer to allow to print additional metadata of the message.Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: